Repository navigation
fetch-polyhaven: add potted_plant_02_1k.glb to the fetch manifest - #76
Open
onebender137 wants to merge 1 commit into
Open
onebender137 wants to merge 1 commit into
onebender137 wants to merge 1 commit into
Conversation
bistro-slice references assets/polyhaven/models/potted_plant_02_1k.glb but the id was missing from every curated set, so a clean setup.ts run left the Bistro scene unrenderable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #73.
polyhaven/models/potted_plant_02_1k.glbis referenced bybistro-slicebut isn't present in any curated set intools/fetch-polyhaven.ts, so a clean setup can't fetch it. Added to thekabukichoset — the onesetup.tsruns by default.Verified by running the fetcher rather than just the manifest edit: the 2.6 MB file downloads.