Repository navigation
gen_signs.py: make the font directory overridable via THREERT_FONT_DIR - #75
Open
onebender137 wants to merge 1 commit into
Open
onebender137 wants to merge 1 commit into
onebender137 wants to merge 1 commit into
Conversation
The stock path /System/Library/Fonts is macOS-only; on Linux the Kabukicho sign generator crashes with 'cannot open resource'. Read an optional THREERT_FONT_DIR env var, defaulting to the macOS path so existing behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Linux half of #73.
tools/kabukicho/gen_signs.pyhardcodesFONT_DIR = "/System/Library/Fonts", which raisesOSError: cannot open resourceon Linux. Becausesetup.tsruns its fetchers sequentially and throws on the first non-zero exit, that crash aborts setup beforefetch-khronos.tsruns — so one font path also strands the Khronos scenes.os.environ.get("THREERT_FONT_DIR", "/System/Library/Fonts")keeps the macOS default and lets other platforms point at their own fonts. Verified with Noto Serif/Sans JP: all 147 sign textures generate.