feat: wire in published DEF CON 34 firmware build - #387
Conversation
The DEF CON 34 build has shipped to
meshtastic.github.io/event/defcon34/firmware-2.8.0.b00d76f, so populate
the edition's firmware block (version/id/title/zipUrl/releaseNotes) that
was null ("coming soon") in the bundled fallback manifest.
Corrects the firmware slug from the provisional defcon2026 to the
published defcon34 — utils/firmwareUrl.ts derives event/{slug}/firmware-{version}
from it, so it must match the real path.
Release notes lead with a preview-build warning.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe DEF CON 34 event firmware configuration now points to preview release ChangesDEF CON 34 firmware
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
meshtastic.github.io/event/defcon34/firmware-2.8.0.b00d76f, so populate the edition's firmware block (version/id/title/zipUrl/releaseNotes) in the bundled fallback manifest (public/data/event_firmware.json), which wasnull("coming soon").defcon2026to the publisheddefcon34—utils/firmwareUrl.tsderivesevent/{slug}/firmware-{version}from it, so it must match the real path.Test plan
public/data/event_firmware.jsonas well-formed JSONevent/defcon34/firmware-2.8.0.b00d76fexists in meshtastic.github.io via the GitHub API?event=DEFCONshows the correct firmware version in the flasher UISummary by CodeRabbit