Add LoRa FEM LNA toggle menu support - #11341
Open
Quency-D wants to merge 2 commits into
Open
Conversation
Contributor
⚡ Try this PR in the Web FlasherNote Building this pull request… the flash button, badges and supported-board |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesLoRa FEM LNA menu
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant User
participant menuHandler
participant LoRaFEMInterface
participant DeviceConfiguration
participant Logger
User->>menuHandler: Select FEM LNA mode
menuHandler->>LoRaFEMInterface: Update and apply LNA state
menuHandler->>DeviceConfiguration: Reload configuration
menuHandler->>Logger: Log FEM LNA state
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an on-device screen menu for controlling the LoRa FEM LNA using the existing
fem_lna_modeconfiguration.This restores the screen control that was removed from #9753 without changing the protobuf definition, FEM driver, or default LNA behavior.
Changes
FEM LNAto the on-device LoRa Actions menu.EnabledandDisabledselections and highlights the current setting.🤝 Attestations
Hardware testing is still required before these attestations can be checked.
Summary by CodeRabbit