Skip to content

Add LC760CA GNSS module support - #11300

Open
Quency-D wants to merge 3 commits into
meshtastic:developfrom
Quency-D:Add-L760CA
Open

Add LC760CA GNSS module support#11300
Quency-D wants to merge 3 commits into
meshtastic:developfrom
Quency-D:Add-L760CA

Conversation

@Quency-D

@Quency-D Quency-D commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Add support for detecting and initializing the LC760CA GNSS module.

Changes

  • Add GNSS_MODEL_LC760CA as a distinct GNSS model.
  • Detect LC760CA modules through the Unicore probe flow using the $PDTINFO response signature $PDTINFO,CC1161W,.
  • Add an LC760CA-specific cached-probe presence check using $PDTINFO,*62.
  • Configure LC760CA modules to output the required GGA and RMC NMEA sentences, using the same $CFGMSG initialization flow as CM121 modules.

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V4

Summary by CodeRabbit

  • New Features
    • Added support for detecting and initializing LC760CA GNSS receivers.
    • Added LC760CA as a recognized GNSS model.
    • Improved receiver verification using LC760CA identification responses.
    • Expanded compatibility with Unicore-family receiver detection.

@github-actions

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

@Quency-D
Quency-D marked this pull request as draft July 31, 2026 10:49
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d38966b-c87d-404a-9512-b63b39e0a646

📥 Commits

Reviewing files that changed from the base of the PR and between 504e318 and 558bf7f.

📒 Files selected for processing (2)
  • src/gps/GPS.cpp
  • src/gps/GPS.h
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/gps/GPS.h
  • src/gps/GPS.cpp

📝 Walkthrough

Walkthrough

The GPS subsystem adds LC760CA as a recognized GNSS model. It verifies and detects LC760CA through $PDTINFO responses and applies the existing CM121 initialization commands.

Changes

LC760CA GPS support

Layer / File(s) Summary
LC760CA model contract
src/gps/GPS.h
Adds GNSS_MODEL_LC760CA to GnssModel_t.
LC760CA probing and initialization
src/gps/GPS.cpp
Verifies cached LC760CA probes with $PDTINFO,*62, maps $PDTINFO,CC1161W, to the new model, and includes LC760CA in the CM121 initialization branch.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding LC760CA GNSS module support.
Description check ✅ Passed The description explains the implementation, detection flow, initialization changes, and testing status, with the required attestation section completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/gps/GPS.h`:
- Line 46: Preserve the existing numeric values in the GnssModel_t enum by
moving GNSS_MODEL_LC760CA after GNSS_MODEL_GENERIC_NMEA; keep
GNSS_MODEL_GENERIC_NMEA at its current value so GPSProbeCacheRecord decoding and
isValidGnssModel() remain compatible with existing probe-cache records.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f0486dde-75bf-4a1c-b931-4a593b89fb61

📥 Commits

Reviewing files that changed from the base of the PR and between 6367132 and 504e318.

📒 Files selected for processing (2)
  • src/gps/GPS.cpp
  • src/gps/GPS.h

Comment thread src/gps/GPS.h
@Quency-D
Quency-D marked this pull request as ready for review August 3, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants