Add LC760CA GNSS module support - #11300
Conversation
⚡ Try this PR in the Web FlasherNote Building this pull request… the flash button, badges and supported-board |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe GPS subsystem adds LC760CA as a recognized GNSS model. It verifies and detects LC760CA through ChangesLC760CA GPS support
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/gps/GPS.h`:
- Line 46: Preserve the existing numeric values in the GnssModel_t enum by
moving GNSS_MODEL_LC760CA after GNSS_MODEL_GENERIC_NMEA; keep
GNSS_MODEL_GENERIC_NMEA at its current value so GPSProbeCacheRecord decoding and
isValidGnssModel() remain compatible with existing probe-cache records.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f0486dde-75bf-4a1c-b931-4a593b89fb61
📒 Files selected for processing (2)
src/gps/GPS.cppsrc/gps/GPS.h
Summary
Add support for detecting and initializing the LC760CA GNSS module.
Changes
GNSS_MODEL_LC760CAas a distinct GNSS model.$PDTINFOresponse signature$PDTINFO,CC1161W,.$PDTINFO,*62.$CFGMSGinitialization flow as CM121 modules.🤝 Attestations
Summary by CodeRabbit