Skip to content

Narrow "PR" candidates (now only 17) - #11294

Merged
vidplace7 merged 1 commit into
developfrom
board_level-sanity
Jul 30, 2026
Merged

Narrow "PR" candidates (now only 17)#11294
vidplace7 merged 1 commit into
developfrom
board_level-sanity

Conversation

@vidplace7

@vidplace7 vidplace7 commented Jul 30, 2026

Copy link
Copy Markdown
Member

These 17 boards should serve as a "canary in the coal mine" when changes are made to the Meshtastic Core. Narrowed significantly to stop wasting time.

Prereq for #11151

Summary by CodeRabbit

  • Bug Fixes
    • Improved board targeting by adjusting or removing board_level overrides across many ESP32, ESP32-S3, nRF52840, RP2040, and RP2350 environments.
    • Ensured builds follow inherited board-level configuration where appropriate for better consistency.
    • Updated select RP2350 devices to use the intended enhanced board-level setting.
    • Preserved existing hardware options, upload methods, build flags, and debug configuration.

@vidplace7
vidplace7 requested a review from thebentern July 30, 2026 17:27
@vidplace7 vidplace7 added the github_actions Pull requests that update GitHub Actions code label Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6c08dcdc-4f42-4846-a81f-b52a09bfb00a

📥 Commits

Reviewing files that changed from the base of the PR and between d1a52be and 507b6ec.

📒 Files selected for processing (27)
  • variants/esp32/rak11200/platformio.ini
  • variants/esp32s3/ELECROW-ThinkNode-M7/platformio.ini
  • variants/esp32s3/elecrow_panel/platformio.ini
  • variants/esp32s3/heltec_v4/platformio.ini
  • variants/esp32s3/meshnology-w10/platformio.ini
  • variants/esp32s3/meshnology-w12/platformio.ini
  • variants/esp32s3/rak3312/platformio.ini
  • variants/esp32s3/seeed-sensecap-indicator/platformio.ini
  • variants/esp32s3/seeed_xiao_s3/platformio.ini
  • variants/esp32s3/station-g2/platformio.ini
  • variants/esp32s3/station-g3/platformio.ini
  • variants/esp32s3/t-eth-elite/platformio.ini
  • variants/nrf52840/heltec_mesh_node_t096/platformio.ini
  • variants/nrf52840/heltec_mesh_node_t1/platformio.ini
  • variants/nrf52840/heltec_mesh_solar/platformio.ini
  • variants/nrf52840/heltec_mesh_tower_v2/platformio.ini
  • variants/nrf52840/rak_wismeshtag/platformio.ini
  • variants/nrf52840/seeed_xiao_nrf52840_kit/platformio.ini
  • variants/nrf52840/t-echo/platformio.ini
  • variants/nrf52840/t-impulse-plus/platformio.ini
  • variants/rp2040/rak11310/platformio.ini
  • variants/rp2040/rpipico/platformio.ini
  • variants/rp2040/seeed_xiao_rp2040/platformio.ini
  • variants/rp2350/diy/pico2_w5500_e22/platformio.ini
  • variants/rp2350/diy/wiznet_5500_evb_pico2_e22p/platformio.ini
  • variants/rp2350/rpipico2/platformio.ini
  • variants/rp2350/seeed_xiao_rp2350/platformio.ini

📝 Walkthrough

Walkthrough

Changes

Board configuration normalization

Layer / File(s) Summary
Remove pr board-level overrides
variants/esp32*/.../platformio.ini, variants/nrf52840/.../platformio.ini, variants/rp2040/.../platformio.ini, variants/rp2350/.../platformio.ini
Most affected environments stop explicitly setting board_level = pr while retaining their existing board and build configuration.
Add pr board-level settings
variants/esp32s3/ELECROW-ThinkNode-M7/platformio.ini, variants/esp32s3/seeed-sensecap-indicator/platformio.ini
Two ESP32-S3 environments explicitly set board_level = pr.
Update RP2350 board levels
variants/rp2350/diy/*/platformio.ini
Two RP2350 environments change board_level from community to extra.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: cleanup

Suggested reviewers: jorropo, thebentern

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far too brief and omits the required template sections, especially the testing attestations. Replace the placeholder text with the repo template sections and complete the attestations/testing checkboxes, including any devices not tested.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly reflects the main change: narrowing the set of PR candidate boards.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch board_level-sanity

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vidplace7
vidplace7 requested a review from Jorropo July 30, 2026 17:28
@vidplace7
vidplace7 force-pushed the board_level-sanity branch from 5066c29 to d4651eb Compare July 30, 2026 17:28
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Flash this PR in the Web Flasher

firmware commit boards expires

Warning

This is an automated, unreviewed CI test build. Back up your device configuration
before flashing, and only flash devices you are able to recover.

Supported boards built by this PR (14)
Device Board Platform
Heltec HT62 heltec-ht62-esp32c3-sx1262 esp32-c3
Heltec Mesh Node T114 heltec-mesh-node-t114 nrf52840
Heltec V3 heltec-v3 esp32-s3
Raspberry Pi Pico W picow rp2040
RAK WisMesh Pocket V3 rak_wismesh_pocket nrf52840
RAK WisMesh Repeater Mini V2 rak_wismesh_repeater_mini nrf52840
RAK WisBlock 4631 rak4631 nrf52840
Seeed SenseCAP Mesh-Tracker-X1 seeed_mesh_tracker_X1 nrf52840
Seeed Wio Tracker L1 seeed_wio_tracker_L1 nrf52840
Seeed SenseCAP Indicator seeed-sensecap-indicator-tft esp32-s3
LILYGO T-Deck t-deck-tft esp32-s3
LILYGO T-Echo Plus t-echo-plus nrf52840
LilyGo T3-C6 tlora-c6 esp32-c6
Seeed SenseCAP T1000-E tracker-t1000-e nrf52840

Build artifacts expire on 2026-08-29. Updated for d1a52be.

@vidplace7
vidplace7 force-pushed the board_level-sanity branch from d4651eb to d1a52be Compare July 30, 2026 18:45
@vidplace7 vidplace7 changed the title Narrow "PR" candidates (now only 18) Narrow "PR" candidates (now only 17) Jul 30, 2026
[env:thinknode_m7]
extends = esp32s3_base
board = ThinkNode-M7
board_level = pr

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaces T-ETH-Elite as our "Ethernet weirdo"

@vidplace7
vidplace7 enabled auto-merge July 30, 2026 19:15
@NomDeTom

Copy link
Copy Markdown
Collaborator

May they find the chokedamp before anyone else.

@vidplace7
vidplace7 disabled auto-merge July 30, 2026 21:05
@vidplace7
vidplace7 enabled auto-merge July 30, 2026 21:08
@vidplace7

Copy link
Copy Markdown
Member Author

This is incidentally including the two children of rak4631... we'll fix it in post (surgical-CI PR)

@vidplace7
vidplace7 disabled auto-merge July 30, 2026 21:19
These boards should be built when changes are made to the Meshtastic Core. Narrowed signficantly to stop wasting time.
@vidplace7
vidplace7 force-pushed the board_level-sanity branch from d1a52be to 507b6ec Compare July 30, 2026 21:20
@vidplace7
vidplace7 merged commit a0c4987 into develop Jul 30, 2026
46 of 47 checks passed
@vidplace7
vidplace7 deleted the board_level-sanity branch July 30, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants