feat: transport driver orientation from config.yaml - default 0 rotation. - #355
feat: transport driver orientation from config.yaml - default 0 rotation.#355caveman99 wants to merge 2 commits into
Conversation
📝 WalkthroughWalkthroughFramebuffer initialization now reads ChangesFramebuffer rotation
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@source/graphics/driver/FBDriver.cpp`:
- Around line 39-44: Update the MESHTASTIC_FB_ROTATION parsing in the
framebuffer rotation initialization to accept only values 0 through 3, removing
the rot & 3 masking behavior. Map each valid value explicitly to its
corresponding lv_display_rotation_t constant, while malformed or out-of-range
values fall back to 0° or emit a warning.
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6709c46e-417f-43d7-85b9-df760a4afd17
📒 Files selected for processing (1)
source/graphics/driver/FBDriver.cpp
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. An unexpected error occurred while generating fixes: Repository rule violations found Required status check "Trunk Check Runner" is expected. |
… screen from config. Requires meshtastic/device-ui#355 and supersedes #10567 and #11138 Many thanks to the original authors https://github.com/a-li3n and https://github.com/jessm33
… screen from config. Requires meshtastic/device-ui#355 and supersedes #10567 and #11138 Many thanks to the original authors https://github.com/a-li3n and https://github.com/jessm33
… screen from config (meshtastic#11252) * add LR 2021 to portduino, and allow Framebuffer devices to rotate the screen from config. Requires meshtastic/device-ui#355 and supersedes meshtastic#10567 and meshtastic#11138 Many thanks to the original authors https://github.com/a-li3n and https://github.com/jessm33 * Build LR2021Interface.cpp in the wasm env initLoRa() constructs LR2021Interface for Lora.Module: lr2021, so excluding the file from the native-wasm source filter left the constructor undefined at link time. LR20x0Interface.cpp stays excluded; it is template-only and comes in via the InterfacesTemplates.cpp amalgamation. Also replace the non-UTF-8 degree signs in the framebuffer rotation comment and correct the rfswitch alias cleanup comment. * Trim comments * Report setenv failure for the framebuffer rotation
This is needed for meshtasticd to specify framebuffer orientation from the confg.yaml.
Summary by CodeRabbit
MESHTASTIC_FB_ROTATIONenvironment variable.