handle regions configuration - #3
Open
fdlamotte wants to merge 1 commit into
Open
Conversation
Author
|
I have a version with dropdown here: https://github.com/fdlamotte/config.meshcore.io/tree/dropdown It's alive at https://frizoncorrea.fr/config.meshcore.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 things to get a full repeater config for deploying repeaters conforming to a common rule:
Regions management is done in its own pane that shares visibility with advanced settings
Configurator fetches region tree as well as home and default regions
Region tree can cleaned. It can also be updated using the region def box. When hitting "Apply def", both tree and home/default fields are updated on the device
Using save settings updates region settings (and applies region def)
When loading a json with a region def defined, everything conforms to the desired configuration (if a region tree is already in the device it is not cleaned, but user can clean before doing save (and the home and default region fields are not emptied so user can just do load json, then save settings and their done, whatever the state is (or near that ;))
Example of json config:
I was thinking we could put this, one line by one line in a json dict and add a drop-down to select profiles ...
doesn't look that bad on one line
{"vars":{"repeat":true,"radio":{"freq":"869.618","bw":"62.5","sf":"8","cr":"8"},"af":10,"flood.max.unscoped":5,"flood.max.advert":6,"flood.advert.interval":24,"advert.interval":0,"guest.password":"","agc.reset.interval":4,"multi.acks":"1","path.hash.mode":1,"loop.detect":"minimal"},"region":{"def":"eu fr","home":"fr","default":"fr"}}