Skip to content

Skip staging SAP HANA client JAR if already present in userlib or vendorlib #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayankmendix merged 4 commits into from
Sep 21, 2026
Merged

Skip staging SAP HANA client JAR if already present in userlib or vendorlib #916

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f558fa
Skip staging SAP HANA client JAR if already present in userlib or ven…
Sep 21, 2026
9980a73
Log JAR version when skipping SAP HANA client download
Sep 21, 2026
e8ff805
Address review: fix glob pattern and simplify skip log
Sep 21, 2026
a8b32d0
Log full JAR path to show whether it came from userlib or vendorlib
Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion buildpack/core/runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import time

import backoff
import glob
import requests
from buildpack import util
from lib.m2ee import M2EE as m2ee_class
Expand Down Expand Up @@ -62,9 +63,19 @@ def _stage_hana_client(build_dir):
if not enabled:
return

model_lib = os.path.join(build_dir, "model", "lib")
for lib_dir in ("userlib", "vendorlib"):
existing = glob.glob(os.path.join(model_lib, lib_dir, "ngdbc-*.jar"))
if existing:
logging.info(
"SAP HANA client JAR [%s] already present, skipping download",
existing[0],
)
return

cdn_prefix = util.BLOBSTORE_BUILDPACK_DEFAULT_PREFIX + "sap-hana-client"
try:
dest = os.path.join(build_dir, "model", "lib", "userlib")
dest = os.path.join(model_lib, "userlib")
util.mkdir_p(dest)
version_url = util.get_blobstore_url(f"{cdn_prefix}/version.txt")
resp = requests.get(version_url, timeout=10)
Expand Down
Loading