Conversation
The Mendix SSO module has been deprecated, so drop the login-with-mendixsso-button.html and login-with-mendixsso-automatically.html templates from the blank web app template, along with the CSS that only supported the button variant's divider and logo image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
login-with-mendixsso-button.htmlandlogin-with-mendixsso-automatically.htmlfrom the Atlas 4 blank web app template (packages/atlas/src/theme/web/), since the Mendix SSO module is deprecated.loginpage-alternativelabel/.loginpage-signindivider styles and the SSO button's logo image styling from_login.scss, since they were only used bylogin-with-mendixsso-button.html(the defaultlogin.htmldoesn't reference them)Test plan
login.htmlrenders unaffected