Skip to content

ci: call the ci-workflows reusable workflows at main - #160

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/float-ci-workflows-callers
Nov 14, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/float-ci-workflows-callers

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: found by listing every caller of a melodic-software/ci-workflows reusable workflow that is pinned below its main.

Summary

This repository called a ci-workflows reusable workflow at an old pinned commit, so its checks still reported that workflow's earlier job names (for example PR Automerge Dependabot / Arm auto-merge for safe Dependabot bumps). The caller now references @main, the form the org's first-party callers use. CI Status stays the only required check.

Fix

  • Each uses: melodic-software/ci-workflows/.github/workflows/<file>.yml@<sha> # <version> becomes @main. Pins of composite actions under .github/actions/ are unchanged.

Verification

  • Compared each reusable workflow's workflow_call interface between the old pin and ci-workflows v0.74.0: inputs were only added, both optional; no input was removed, renamed or made required, and no secret or job permission changed. The caller's with: and permissions: blocks still fit.
  • The org runner policy accepts a ci-workflows reusable workflow at @main (melodic-software/standards components/runner-policy/runner-policy.mjs).
  • Behaviour that arrives with the newer workflow: pr-automerge-dependabot.yml also arms patch and minor uv updates and checks the pull request's title and body against the update metadata.
  • Left out: a local run; CI on this pull request exercises the caller.

Related

🤖 Generated with Claude Code

The callers were pinned to an old ci-workflows commit, so their checks
still reported the reusable jobs' earlier names. The org's first-party
callers float on main; composite action pins are unchanged.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 14, 2026 20:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T20:23:32.420247Z af75825 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed af7582578b54831199ad371a9b5952729b28fc53: 0 finding(s), 0 as inline comments.

No security findings.

The PR changes one line. In .github/workflows/pr-automerge-dependabot.yml, the uses: ref for melodic-software/ci-workflows/.github/workflows/pr-automerge-dependabot.yml moves from a v0.50.0 commit SHA pin to @main.

  • Pin loosening: this moves from a pinned SHA to a moving branch ref, and the called workflow runs with contents: write and pull-requests: write. Loosened pins are the zizmor advisory lane's territory, so this review does not re-report it. It is also the owner's "pin or repin ceremony" friction hold, which the throughput-phase section says is not a finding. I am noting the removal here and holding nothing for it.
  • Who can reach it: the ref points at the org's own melodic-software/ci-workflows repository, so the PR author does not control what main contains. The trigger is plain pull_request and not pull_request_target. The top-level permissions: {} and the job-level grants are unchanged. A forked head gets a read-only token regardless.
  • Other changes: the diff adds no secrets, no new token scope, no new trusted actor and no manifest changes.
  • Dropped candidates: none.

manifest fields: none hit.
critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed af7582578b54831199ad371a9b5952729b28fc53: 0 finding(s), 0 as inline comments.

No findings. The PR changes one line in .github/workflows/pr-automerge-dependabot.yml: the uses: ref goes from a pinned SHA (# v0.50.0) to @main.

  • Consistency: I checked the other reusable-workflow callers under .github/workflows/. pr-review-hosted.yml:85 and pr-review-security-hosted.yml:78 already call ci-workflows at @main, so this change matches the existing pattern. The composite-action pins under .github/actions/ are untouched, as the PR says.
  • Caller interface: the with: runner: input and the contents: write and pull-requests: write grants are unchanged and still read as valid caller-side config. I did not fetch the upstream workflow_call interface, so the author's "inputs only added, both optional" comparison is author-claimed and unverified by me.
  • Closing issue: the PR states "No related issue" with a reason, so there are no acceptance criteria to check.
  • Manifests: none changed.
  • Security: a mutable @main ref on a caller that grants contents: write is a supply-chain trade-off. It is the org's own first-party repo, matches the other callers, and the PR cites the runner policy as accepting it. I report it as a note, not a finding, and leave any security judgment to the security lane.
  • Stale comment, not counted: the header comment of the caller (lines 3-5) says it arms auto-merge only for "allowlisted GitHub Actions publishers (actions/*, github/*, anthropics/*)". The PR body says the newer workflow also arms patch and minor uv updates. The comment will understate that once this merges. I could not check the upstream behavior myself, so I did not post it inline. The author may want to confirm and reword the comment.
  • Tests: none apply. The change is CI wiring with no local test surface, and the PR says the CI run on this pull request exercises the caller.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit f483d4d into main Nov 14, 2026
14 checks passed
@kyle-sexton
kyle-sexton deleted the ci/float-ci-workflows-callers branch November 14, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant