Skip to content

ci: call the ci-workflows reusable workflows at main - #191

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/float-ci-workflows-callers
Nov 14, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/float-ci-workflows-callers

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: found by listing every caller of a melodic-software/ci-workflows reusable workflow that is pinned below its main.

Summary

This repository called a ci-workflows reusable workflow at an old pinned commit, so its checks still reported that workflow's earlier job names (for example PR Automerge Dependabot / Arm auto-merge for safe Dependabot bumps). The caller now references @main, the form the org's first-party callers use. CI Status stays the only required check.

Fix

  • Each uses: melodic-software/ci-workflows/.github/workflows/<file>.yml@<sha> # <version> becomes @main. Pins of composite actions under .github/actions/ are unchanged.

Verification

  • Compared each reusable workflow's workflow_call interface between the old pin and ci-workflows v0.74.0: inputs were only added, both optional; no input was removed, renamed or made required, and no secret or job permission changed. The caller's with: and permissions: blocks still fit.
  • The org runner policy accepts a ci-workflows reusable workflow at @main (melodic-software/standards components/runner-policy/runner-policy.mjs).
  • Behaviour that arrives with the newer workflow: pr-automerge-dependabot.yml also arms patch and minor uv updates and checks the pull request's title and body against the update metadata.
  • Left out: a local run; CI on this pull request exercises the caller.

Related

🤖 Generated with Claude Code

The callers were pinned to an old ci-workflows commit, so their checks
still reported the reusable jobs' earlier names. The org's first-party
callers float on main; composite action pins are unchanged.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 14, 2026 20:11
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T20:13:19.477780Z 2be0c75 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 2be0c754a5de17fae3a8f297071cb8048394cf33: 0 finding(s), 0 as inline comments.

Security review: PR #191 (head 2be0c75)

Findings: 0. critical-findings: 0

The PR changes one line in .github/workflows/pr-automerge-dependabot.yml:27. It moves the uses: reference for melodic-software/ci-workflows/.github/workflows/pr-automerge-dependabot.yml from a commit SHA (d223a64…, v0.50.0) to the mutable ref @main.

What I checked

  • Trigger: the workflow runs on pull_request, not pull_request_target or workflow_run (line 13). A fork head gets a read-only token, so an outside contributor cannot use the loosened pin to reach the write grant.
  • Permissions: the caller's grants are unchanged. It keeps permissions: {} at the top level and contents: write and pull-requests: write on the job (lines 15, 24-26). The PR does not grow any token's scope.
  • Inputs: the with: runner: ubuntu-24.04 input is unchanged. No secrets are passed.
  • Trust controls: the file is not under .github/actions/, the trusted-actor list, CODEOWNERS or .gitmodules. It does not widen who is trusted, and it does not touch the kill switch or the token broker. The workflow arms auto-merge, and GitHub still requires the CI Status check before it merges.

Pin loosening. Swapping a SHA pin for @main is a supply-chain pin change. Zizmor's advisory lane covers unpinned or loosened action pins (the unpinned-uses class), so I do not report it again here. The target is an org-owned repository. Under the throughput-phase threat model in the skill, weakening a pin or repin ceremony is not a finding. The only thing a main push to ci-workflows reaches is a workflow the owner already controls.

Manifests: no plugin.json or marketplace.json change.

Context files: none supplied (no PR CONTEXT:, SETTLED THREADS: or PRIOR FINDINGS: lines).

@github-actions

Copy link
Copy Markdown

claude-review reviewed 2be0c754a5de17fae3a8f297071cb8048394cf33: 0 finding(s), 0 as inline comments.

No findings. The diff is one line: the uses: reference in .github/workflows/pr-automerge-dependabot.yml moves from a pinned SHA (# v0.50.0) to @main.

  • Scope and permissions: The caller's with: and permissions: blocks are unchanged. contents: write and pull-requests: write stay the same.
  • Manifests: No plugin manifests changed, so no manifest <field> lines apply.
  • PR body contract: The title is Conventional Commits. The body opens with No related issue: <reason> and has the Summary, Fix, Verification and Related sections.
  • Closing issue: None, so there are no acceptance criteria to check.
  • Unverified author claims: I did not independently check the author's claims about the workflow_call interface comparison, the runner policy accepting @main, or the newer workflow's behavior. The runner-policy file and the ci-workflows history were not in the diff, so I treat those as author-claimed and unverified.
  • Not rated as a finding: Pointing a contents: write caller at a moving @main ref means any later change to the org's reusable workflow takes effect here without a review in this repository. That is a deliberate org-wide policy the PR states, and it belongs to the security lane, so I did not report it.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 1c8c7e3 into main Nov 14, 2026
10 checks passed
@kyle-sexton
kyle-sexton deleted the ci/float-ci-workflows-callers branch November 14, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant