Skip to content

docs(upstream): record the feedback-loops workshop and correct two stale claims - #16664

Merged
kyle-sexton merged 2 commits into
mainfrom
docs/upstream-feedback-loops
Nov 16, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
docs/upstream-feedback-loops

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: the record closes the Feedback Loops workshop's absorb pass; each row links the pull request that landed it.

Summary

Adds the docs/upstream record for the Feedback Loops workshop of AI Hero Cohort 005, and corrects
two claims that had gone stale: the diagnosing-bugs row in the mattpocock-skills record, and an
unsourced line about GitHub's video player in the explainer-video README.

Fix

  • docs/upstream/aihero-feedback-loops.md (new): per idea, what it does, the problem behind it
    upstream and here, and a take, adapt, already-have, reject or no-change disposition with the pull
    request that landed it. It uses the per-idea table of aihero-review.md and
    aihero-codebase-design.md rather than the lane layout of aihero-shipping-course.md, because
    this workshop's work landed as independent pull requests, not lanes under a spec container. No
    lesson text, caption, image or code is copied.
  • docs/upstream/mattpocock-skills.md, row diagnosing-bugs: the minimize step, the Phase 1 exit
    check and the clean-copy diff it listed as open gaps or "not taken" had landed (feat: adopt the 2,000-PRs talk decisions across the marketplace #7009, feat(debugging): add minimize, pristine-copy diff and HITL template note to debugging:debug #8828);
    the row now also records what feat(debugging): add a diagnose action and a Phase 1 surface pass #16617 took (the glossary read) and added (the diagnose action,
    the Phase 1 surface pass). Re-checked at upstream HEAD 5863806: nothing under the skill changed
    since the page's pin, so the row link keeps the pin.
  • plugins/explainer-video/README.md: drops "GitHub's player shows no soft captions". GitHub's
    Attaching files page says nothing about caption tracks and no GitHub changelog entry was found,
    so the clause had no source. A no-release changelog fragment goes with it.

Verification

  • markdownlint-cli2 with the repo config on the three markdown files: 0 issues; typos and
    scripts/check-vocabulary.py on them: clean; scripts/check-cost-figures.sh: no cost figure.
  • lychee with lychee.toml (online, fragments included) on both records and the README: 231
    links OK, 0 errors; scripts/check-upstream-drift.sh --links --page docs/upstream/mattpocock-skills.md:
    69 links ok.
  • A five-word-run comparison of the new record against the lesson text and captions, and of the
    rewritten row against upstream SKILL.md at 5863806: no shared run except the lesson title.
    Every pull request the record links as landed reads MERGED (read 2026-11-16); feat(app-control): bring map refresh in line with the maintain-verification-skill upkeep pass #16481 is open
    and its rows say pending.

Related

🤖 Generated with Claude Code

kyle-sexton and others added 2 commits November 16, 2026 18:33
…ale claims

Add docs/upstream/aihero-feedback-loops.md, the record for the Cohort 005
Feedback Loops workshop: per idea, what it does, the problem behind it,
our disposition and the merged pull request that carries it.

Rewrite the diagnosing-bugs row in mattpocock-skills.md: the minimize
step, the Phase 1 exit check and the clean-copy diff it called open gaps
had all landed (#7009, #8828), and #16617 added the glossary read, the
diagnose action and the Phase 1 surface pass. Re-checked at upstream
HEAD 5863806; nothing under the skill changed since the pin.

Drop the unsourced clause in the explainer-video README that GitHub's
video player shows no soft captions; GitHub's Attaching files page says
nothing about caption tracks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…EADME edit

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 23:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T23:38:07.184692Z 2bddc9c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/fix-docs
Model rung 0
Leg handoff
Run job success
Activity step success
Commits pushed none (read lane)
Run 43980825965

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 2bddc9cdb4e1d76a696aca8e1b9a582c3b3e3930: read 4 of 4 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #16664, no findings

I read every hunk of all 4 changed files in the full diff.

  • .changes/explainer-video/docs-upstream-feedback-loops-f6042387.md (new): a changelog fragment marked bump: none, with a one-line description.
  • docs/upstream/aihero-feedback-loops.md (new, under the trusted path docs/upstream/**): an attribution record of dispositions. Its links point at public docs, at PRs in this repository and at upstream mattpocock/skills URLs pinned to commit 4ae2317ddb22b046e26455e4f9c9b3aaaf62212d. It has no directives aimed at a lane or agent, no executable content and no secrets. It changes no trust control, token scope, merge hold or kill switch.
  • docs/upstream/mattpocock-skills.md (trusted path): one attribution row (diagnosing-bugs) rewritten. The row only describes what was taken; the upstream link keeps the same pinned SHA.
  • plugins/explainer-video/README.md: one unsourced clause removed from the README prose. No code, manifest or userConfig change.

What the review checked:

  • Instruction surfaces: none of the changed files is a standing instruction (CLAUDE.md, AGENTS.md, a rules file, a skill or agent body, a hook list), so nothing a guardrail enforced is deleted or softened.
  • Plugin manifests: no plugin.json or marketplace.json changed.
  • PR description: it contains no text directing this lane to pass the PR, skip a check, drop a finding or post elsewhere.

No security issues found.

critical-findings: 0

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 2bddc9cdb4e1d76a696aca8e1b9a582c3b3e3930: read 4 of 4 changed file(s); 0 finding(s), 0 as inline comments.

Code review: PR #16664, docs(upstream): record the feedback-loops workshop and correct two stale claims

I found no problems. I read every hunk of all 4 changed files in the full diff. The PR only touches docs: a new upstream record, one rewritten attribution row, one README clause removed, and a changelog fragment with bump: none.

What I checked myself (Read, Grep and Glob only; I ran nothing):

  • Relative links in docs/upstream/aihero-feedback-loops.md.

    • The repo has every sibling aihero-*.md record it links.
    • ADR 0072 and ADR 0086 exist.
    • All nine plugin skill and reference paths it links exist (codify, enforcement-ladder, debug, mutation-testing audit and principles, test-value, implement, drive, playwright).
    • The What a row may describe anchor exists in docs/contracts/upstream-drift/README.md.
  • The #not-adopted anchor in the rewritten mattpocock-skills.md row points to the ## Not adopted heading at line 65 of that file.

  • The rewritten diagnosing-bugs row matches plugins/debugging/skills/debug/SKILL.md as it stands now:

    • the diagnose action (line 47)
    • the Phase 1 surface pass (line 105)
    • the Minimize step with its gate before Phase 3 (lines 226–235)
    • the glossary read first in Phase 3 (line 250)
    • the step that diffs an edited file against a clean copy (line 316)

    So the old row was stale, as the PR says.

  • README edit and fragment. The README edit only removes one unsourced clause, and the bump: none fragment fits a change that ships nothing.

Not verified by me (author-claimed): the PR body's results for lychee, markdownlint, typos and the vocabulary check, the five-word-run copy check, and the MERGED state of each linked pull request.

Other checks:

  • No plugin manifest changed, so there are no manifest lines.
  • The pull request closes no issue, so there are no acceptance criteria to check.
  • There were no earlier findings from this lane and no settled threads.
  • The PR context had no embedded instructions to report.
  • docs/upstream/** is a trusted path. It holds only documentation here, and I reviewed its whole change.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 2a26f3a Nov 16, 2026
78 checks passed
@kyle-sexton
kyle-sexton deleted the docs/upstream-feedback-loops branch November 16, 2026 23:58
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant