Repository navigation
feat(intake-triage): admit trusted upstream-drift issues by one shared rule #16620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+584
−89
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8c5a2a3
feat(intake-triage): admit trusted upstream-drift issues by one share…
kyle-sexton 2f3a833
feat(intake-triage): carry trusted drift issues through every author …
kyle-sexton db5c7de
fix(work-unblock): unpark a trusted drift issue once its blocker closes
kyle-sexton ee6cf52
Merge remote-tracking branch 'origin/main' into feat/14215-admit-drif…
kyle-sexton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
.changes/pr-pipeline/feat-14215-admit-drift-issues-c9965580.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| bump: minor | ||
| --- | ||
|
|
||
| ### Changed | ||
|
|
||
| - A trusted upstream-drift issue (github-actions[bot] wrote it, nobody else last edited it, and its title and first body line are the filer's) reaches the issue lane with no owner step. One rule in `admit.mjs` (`driftIssueId`, through `authorTrust` for a REST read) decides it at every author gate: the triage sweep, which now dispatches intake for it while still skipping every other github-actions[bot] issue; `apply-verdict.mjs`; admission criteria 7 and 9; `check-blockers.mjs`; and `write-issue.mjs`. pr-verify reads the same rule. Its spec is one fixed template (`driftSpecText`) built from the upstream id, with done-when items and the design-change stop, never from its body; pr-verify's drift spec gains those lines. Such an issue is never split: admission takes it at any Size and the lane runs it at `split-child-size`. The filer's own body rewrite after admission no longer stops the lane run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.