Repository navigation
feat(source-control): show small-change evidence inline and add an optional record block - #16616
Conversation
…tional record block The pull-request evidence comment now leads with the run's text result, lays out a small change (at most two acceptance criteria and at most evidence_inline_max_captures captures, default 4) as a Before/After table, and keeps collapsed sections for a larger change. A team can turn on evidence_record_fields to add who verified, when, and the issues found with their resolution. Both keys are read at the pull request's base by read-evidence-layout.sh. The verdict and leak-scan gates are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MWmASPFjTu4anSp6BowqVC
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A change with no capture keeps collapsed sections, the capture line names the PR's base branch for the Before row, the leak scan reads the --before file's hub too, each publishable list resolves against its own file's directory, a video reference takes the capture path check, and every table cell escapes pipes and line breaks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MWmASPFjTu4anSp6BowqVC
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e95a711aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…nt at the video rule With --before, each capture in a collapsed section carries a Before (base) or After (head) label line and alt prefix, since a base and a head capture can share a file name. The video paragraph keeps its instruction and the pointer to GitHub's embedding section without restating the upstream behavior. The large-change eval now uses shared file names and grades the run labels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MWmASPFjTu4anSp6BowqVC
|
claude-security-review reviewed Security review (incremental, acb793e since 30ffb8b; blocking only)This review covers one file changed since No security issues in this push. What changed. At
Instruction surface. I did not consult the protected-class register because the edit removes no rule. Outside this push's scope. The eval-only Embedded text. I found no embedded instructions in the PR context or the settled threads. critical-findings: 0 |
|
claude-review reviewed Incremental code review: acb793e (since 30ffb8b), blocking findings onlyThis lane already reviewed earlier heads, so this pass reports blocking findings only. I read the whole incremental change: one hunk in 1 of 1 listed files, What changed
FindingsNone blocking. Other notes
Verifier dropped 0 of 0 candidates. |
|
Held for the owner's review of the decisions behind this change. The hold comes off when the owner confirms them. |
…tions The Before/After table now applies only when every capture maps to an entry point through a drive report.json step. An e2e-summary.json input, or any capture no step lists, keeps the collapsed layout with its Other captures section, so every capture has a place. A new eval case covers an e2e-summary.json input. The FDA citation points at the guidance's HTML page, which automated link checks can load. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MWmASPFjTu4anSp6BowqVC
|
Hold lifted: the owner reviewed and confirmed the decisions behind this change (2026-11-16). |
… dead link The fda.gov guidance URL now redirects to a 404, which fails the online link check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: an owner-decided change to the pull-request skill's evidence comment layout.
Summary
The
/source-control:pull-request evidencecomment now leads with the run's text result and sizes its media to the change: a small change shows its Before/After captures inline as a table, and a larger change keeps one collapsed section per acceptance criterion. A repository can switch on a record block (who ran the verification, when, and the issues found with their resolution) for teams that keep such a record. The verifier-verdict and leak-scan posting gates are unchanged.Fix
skills/pull-request/reference/evidence.md,templates/evidence-comment.md: one template, two layouts. A change is small when it has at most two sections (acceptance criteria, else entry points) and at mostevidence_inline_max_capturescaptures, Before and After counted together. Small renders a table with one column per interaction,BeforeandAfterrows, a caption under each image, and one line naming the capturing tool and what each row's state means. Videos go in their own paragraph under the table, since a video plays only alone in a paragraph. Images stay markdown references, never<img>tags, sogh --attachrewrites them.0keeps every change in collapsed sections.--before <file>(the base run's evidence file, held to its ownpublishablelist and the same sidecar check),--verified-by,--issues.evidence_record_fields(defaultfalse) adds the record block. A missing value rendersnot recordedand never stops the post. The fields follow the record elements in FDA's Computer Software Assurance guidance, section (6), as an analogy for regulated teams, not a legal requirement.scripts/read-evidence-layout.sh(+ tests) reads both keys fromdocs/conventions/source-control.yamlat the pull request's base, honored only when the base is the default branch, likereview_venue. NouserConfigoption: both are repository policy. Schema andreference/config-resolution.mddocument the keys; SKILL.md's action row and create.md's Visual evidence paragraph point at the new layout.evals/fixtures/gh-forge/gh:pr comment --helplists the flags,--attachamong them.Verification
bash plugins/source-control/skills/pull-request/scripts/read-evidence-layout.test.sh: all pass.bash scripts/check-convention-yaml.sh,bash scripts/check-convention-yaml.test.sh,read-pre-ready.test.sh: pass.markdownlint-cli2on the changed markdown: clean.shellcheckon the new scripts: clean.validate-cases.py plugins/source-control/evals: the new cases load and every deterministic grader passes and rejects its samples as written.claude plugin eval(Claude Code 2.1.325, with-plugin arm only, 2 runs per case) on the three new cases: 6/6 runs scored 1.00, every grader passing. The first run caught a fixture gap: the eval forge'sghdid not answerpr comment --help, so the model took step 7's no-attach fallback and rendered no table. The forge now lists thepr commentflags.Left out: the CI pr-merge lane's evidence comment (
babysit_evidence_comment.py) attaches no file and already leads with text; it does not render the table or the record block.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01MWmASPFjTu4anSp6BowqVC