Skip to content

docs(pr-pipeline): say GITHUB_TOKEN pull request runs wait for approval - #16613

Open
kyle-sexton wants to merge 2 commits into
mainfrom
docs/github-token-approval-required-runs
Open

kyle-sexton wants to merge 2 commits into
mainfrom
docs/github-token-approval-required-runs

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: docs correction after GitHub changed how GITHUB_TOKEN pull request events start runs.

session: AI Hero

Summary

GitHub's Triggering a workflow from a workflow now says that when GITHUB_TOKEN opens, reopens or pushes to a pull request, "the resulting pull_request event creates workflow runs in an approval-required state". Other GITHUB_TOKEN events (a push, labels, issues) still start no run. Four statements here said such a pull request write starts no run.

Fix

  • docs/conventions/pr-pipeline/README.md, identity table: the GITHUB_TOKEN row names the pull request exception and links GitHub's section; the lanes App row (the write identity of pr-unblock, pr-refine and work-resolve-issue) says the App starts the next lane's runs unattended, where a GITHUB_TOKEN pull request push starts them only after approval.
  • .changes/pr-pipeline/ fragment (patch) for the README change.
  • release-publish-plugins.yml and release-generate-dependabot-changelog-fragments.yml header comments: the same correction, matching the README's release App row.

Comments and prose only; no workflow behavior changes. ADR 0085 is left to its own open pull request.

Verification

  • Read GitHub's section this session (2026-11-16) and quoted only what it says.
  • markdownlint-cli2 on the README: 0 issues.
  • Other GITHUB_TOKEN no-run statements in .github/workflows, .github/scripts and the pipeline README concern workflow_run, label, issue or status events, which the page still says start no run; left unchanged.

Related

  • ADR 0085 makes the same claim; its amendment is a separate open pull request.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2

kyle-sexton and others added 2 commits November 16, 2026 14:16
GitHub now creates `pull_request` runs in an approval-required state when
GITHUB_TOKEN opens, reopens or pushes to a pull request. The identity table
and the release workflow headers said such a write starts no run; they now
say the runs wait for approval and point at GitHub's section.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 19:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T19:24:28.804369Z a5c3c23 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed a5c3c234e7626b89b05b97999511c935c06d65cd: read 4 of 4 changed file(s); 0 finding(s), 0 as inline comments.

I found nothing to flag in this pull request. It only changes prose and comments: the GITHUB_TOKEN and Lanes App rows of the identity table in docs/conventions/pr-pipeline/README.md, the header comments of the two release workflows, and a patch changelog fragment. No workflow behavior changes.

  • Correctness: the new wording says a pull request that GITHUB_TOKEN opens or pushes to gets pull_request runs that wait for approval, and that its other writes still start no run. That matches the GitHub doc the PR quotes. I did not fetch the doc myself, so that quote is the author's and unverified. The new wording also matches the Release App row (README line 3590), which this PR leaves unchanged.
  • Leftover old claims: I searched the README and workflows for "GITHUB_TOKEN … starts no run" statements. The ones left concern labels, issues, statuses or label removal, for example README line 4221 and the comments in pr-require-checks.yml, work-unblock.yml and intake-triage.yml. The doc's pull request exception does not cover those, so they are still accurate. The PR leaves ADR 0085's matching claim to a separate pull request, as it says.
  • Closing issue: none (the PR says "No related issue").
  • Changelog fragment: bump: patch fits a documentation correction.
  • Plugin manifests: none changed.
  • Prior findings: none, and this is not a blocking-only review.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed a5c3c234e7626b89b05b97999511c935c06d65cd: read 4 of 4 changed file(s); 0 finding(s), 0 as inline comments.

Security review: no security issues found

critical-findings: 0

I read the whole change in all 4 files. Nothing in this PR changes how anything runs:

  • .github/workflows/release-publish-plugins.yml and .github/workflows/release-generate-dependabot-changelog-fragments.yml (trusted paths): only the header comments change. Both now say a pull request opened or updated with GITHUB_TOKEN gets its pull_request runs only after approval, instead of no runs. No on: trigger, permissions: block, if: condition, token request, step or pin changes. The release App identity and how it is used are unchanged.
  • docs/conventions/pr-pipeline/README.md: two rows of the write-identity table get clearer wording about which runs a GITHUB_TOKEN write can start. It is a description, not an instruction, so the instruction-surface lens does not apply.
  • .changes/pr-pipeline/…d3d999e5.md: a new patch changelog fragment.

No trust control changes: the trusted-trigger check, the lanes token scope, the kill switch, the broker's grants and the merge holds are all untouched. No plugin manifests are touched. The PR context has no embedded instructions aimed at this review. There are no prior findings, and this is the first review of this pull request, not a blocking-only one.

Spend: none.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant