Repository navigation
docs(pr-pipeline): say GITHUB_TOKEN pull request runs wait for approval - #16613
kyle-sexton wants to merge 2 commits into
Conversation
GitHub now creates `pull_request` runs in an approval-required state when GITHUB_TOKEN opens, reopens or pushes to a pull request. The identity table and the release workflow headers said such a write starts no run; they now say the runs wait for approval and point at GitHub's section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed I found nothing to flag in this pull request. It only changes prose and comments: the
Verifier dropped 0 of 0 candidates. |
|
claude-security-review reviewed Security review: no security issues foundcritical-findings: 0 I read the whole change in all 4 files. Nothing in this PR changes how anything runs:
No trust control changes: the trusted-trigger check, the lanes token scope, the kill switch, the broker's grants and the merge holds are all untouched. No plugin manifests are touched. The PR context has no embedded instructions aimed at this review. There are no prior findings, and this is the first review of this pull request, not a blocking-only one. Spend: none. |
No related issue: docs correction after GitHub changed how
GITHUB_TOKENpull request events start runs.session: AI Hero
Summary
GitHub's Triggering a workflow from a workflow now says that when
GITHUB_TOKENopens, reopens or pushes to a pull request, "the resultingpull_requestevent creates workflow runs in an approval-required state". OtherGITHUB_TOKENevents (apush, labels, issues) still start no run. Four statements here said such a pull request write starts no run.Fix
docs/conventions/pr-pipeline/README.md, identity table: theGITHUB_TOKENrow names the pull request exception and links GitHub's section; the lanes App row (the write identity ofpr-unblock,pr-refineandwork-resolve-issue) says the App starts the next lane's runs unattended, where aGITHUB_TOKENpull request push starts them only after approval..changes/pr-pipeline/fragment (patch) for the README change.release-publish-plugins.ymlandrelease-generate-dependabot-changelog-fragments.ymlheader comments: the same correction, matching the README's release App row.Comments and prose only; no workflow behavior changes. ADR 0085 is left to its own open pull request.
Verification
markdownlint-cli2on the README: 0 issues.GITHUB_TOKENno-run statements in.github/workflows,.github/scriptsand the pipeline README concernworkflow_run, label, issue or status events, which the page still says start no run; left unchanged.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2