Skip to content

chore(settings): enable source-control and app-control for this repo - #16607

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/enable-instructed-plugins
Nov 16, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
chore/enable-instructed-plugins

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: owner decision to enable in the repository settings the plugins this repository's own instructions tell every session to use.

session: AI Hero

Summary

AGENTS.md tells every session to open and ready pull requests with /source-control:pull-request (lines 5, 10, 68, 71, 78, 79) and to drive skills with /app-control:drive (line 130). .claude/settings.json did not enable either plugin. This PR enables both.

Slash names found in the instruction files (grep -oE '/[a-z-]+:[a-z-]+' over AGENTS.md, CLAUDE.md and .claude/rules/):

Reference Plugin Where Added?
/source-control:pull-request source-control AGENTS.md, always loaded yes
/app-control:drive app-control AGENTS.md, always loaded yes
/evals:design evals .claude/rules/eval-case-transcripts.md, path-scoped no, already enabled
/docs-hygiene:rename-references docs-hygiene .claude/rules/skill-bodies-state-current-rules.md, path-scoped no, the rule says "when that plugin is enabled; otherwise grep the old token"
/session-flow:workflow session-flow same rule, path-scoped no, it names which skill owns stage routing and does not tell a session to invoke it

Fix

  • .claude/settings.json: add app-control@melodic-software: true and source-control@melodic-software: true to enabledPlugins, in byte order. Nothing else changes.
  • Cost the gate header records (scripts/check-plugin-catalog-enablement.sh:18-20): each enabled key writes one project-scope install record per checkout on local session start. Two keys add two records.

Marketplace resolution for a fresh clone: not changed

A fresh clone resolves the melodic-software marketplace in a cloud session, where .claude/cloud-bootstrap.sh:188-193 registers the checkout. A local clone resolves it only through the user's own registration, because the bootstrap exits on non-cloud sessions (.claude/cloud-bootstrap.sh:40-43). On a local machine with no registration, the two new keys name an unknown marketplace and install nothing. Project enabledPlugins "doesn't install them" (settings reference: enabledPlugins).

This PR does not add an extraKnownMarketplaces.melodic-software entry. The repository forbids one on purpose:

  • scripts/check-plugin-catalog-enablement.sh:173-183 (SHADOWING) fails CI on it.
  • .claude/cloud-bootstrap.sh:127-131 records that the project settings declare no marketplace.

The docs confirm the mechanism. When several settings files define the same marketplace name, the highest-precedence entry is used whole (settings reference: extraKnownMarketplaces), and project settings outrank user settings (settings precedence). A project github entry would therefore replace contributors' own registrations and the cloud bootstrap's directory registration, so cloud sessions would serve published main instead of the branch. Changing that is left to the owner.

Verification

  • enabledPlugins before (origin/main at 9782ef1): ai-slop, animation (false), attribution, discipline, docs-naming, evals, explainer-video, gaming (false), guardrails, harness-config, harness-ops, instruction-placement, pixel-art (false), playgrounds (false), plugin-quality, retro-audio (false), skill-quality, speech.
  • After: the same list plus app-control@melodic-software: true and source-control@melodic-software: true.
  • Spelling of the ids:
    • .claude-plugin/marketplace.json has name: "melodic-software" and entries app-control (./plugins/app-control) and source-control (./plugins/source-control).
    • plugins/app-control/.claude-plugin/plugin.json and plugins/source-control/.claude-plugin/plugin.json give the same name values.
  • scripts/check-plugin-catalog-enablement.sh passes: "Every enabledPlugins key for 'melodic-software' names one of the 95 catalogued plugins; none orphaned; keys sorted; .claude/cloud-bootstrap.sh installs that same marketplace."
  • Check that pins the plugin list: none. A search of scripts/ and .github/ for enabledPlugins finds the gate above, which checks key names and order, and test files that use their own fixtures. No expectation needed updating.

Related

  • Owner decision: when a local clone has no melodic-software registration, should the project settings register the marketplace? Option A, recommended: keep the current behavior. A contributor runs claude plugin marketplace add melodic-software/claude-code-plugins once. Option B: add an extraKnownMarketplaces github entry and remove the SHADOWING check. That overrides contributors' registrations and the cloud directory registration in this repository.

🤖 Generated with Claude Code

https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2

AGENTS.md tells every session to open and ready pull requests with
/source-control:pull-request and to drive skills with /app-control:drive,
but .claude/settings.json did not enable either plugin. Enable both,
keeping the keys in byte order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 19:12
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T19:14:08.023444Z 54eac80 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 54eac8037ab1bd327d351c0138c27389bc33faa8: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #16607 (head 54eac80)

I read the full diff (1 file, .claude/settings.json, a trusted path) and the PR context. There are no earlier findings from this lane; this is the first review of this PR, so it is not blocking only.

Change: two keys are added to the project's enabledPlugins: app-control@melodic-software: true and source-control@melodic-software: true. Nothing else changes.

What I checked:

  • What the new keys load. plugins/app-control/.claude-plugin/plugin.json declares no hooks, mcpServers, lspServers, monitors or dependencies. plugins/source-control/hooks/hooks.json adds these hooks:

    • PreToolUse gates that only block: the PR-body linkage check and the git worktree add containment check.
    • A PostToolUse worktree claim.
    • WorktreeCreate and WorktreeRemove hooks that place and clean up worktrees.

    All of them run plugin code from this repository's own marketplace entries. None mints or widens a token, adds a trusted actor, or sends untrusted text to a lane. The source-control userConfig guards keep their safe defaults: babysit_default_tier: "safe", babysit_autopilot_merge_tier: false, babysit_stacked_prs: false. The PR changes none of them.

  • CI lanes. No workflow under .github/workflows/ registers the melodic-software marketplace: a search for marketplace add and extraKnownMarketplaces found nothing. The project settings declare no marketplace either; the repository's SHADOWING check forbids one. So in an Actions run, these keys name a marketplace the session doesn't know and install nothing. Enabling a plugin also adds no skill to any activity's allowlist, so what a lane session may invoke is unchanged.

  • Trust controls. None is touched: trusted-trigger, lane token scope, kill switch, merge holds and the broker config all have no changes. Nothing is widened.

  • Instruction surface. Nothing is deleted or loosened; the change only adds keys.

  • Manifests. No .claude-plugin/plugin.json or marketplace.json changes, so I recorded no manifest lines.

Spend: each enabled key writes one project-scope plugin install record per checkout when a local session starts. That costs no money and is not a hold.

Embedded text: none. The PR context contains no instructions aimed at this lane.

Result: no security issues found.

critical-findings: 0

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 54eac8037ab1bd327d351c0138c27389bc33faa8: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code review: PR #16607, enable source-control and app-control in .claude/settings.json

No findings. I read the whole diff: 1 file, 2 added lines.

What I checked:

  • Key placement. app-control@melodic-software sits between animation and attribution. source-control@melodic-software sits between skill-quality and speech. Both are in byte order, which is what the repo's enablement gate requires. The JSON at head is well-formed (settings.json#L65, #L81).
  • Plugins exist. Both have a plugins/<name>/.claude-plugin/plugin.json, so neither key is orphaned.
  • Closing issue. None. The PR body says this was the owner's decision, so there are no acceptance criteria to check against.
  • Author's verification. The author says scripts/check-plugin-catalog-enablement.sh passes. I could not run it in this lane, so that is the author's claim and I have not confirmed it.
  • No .claude/rules or paved-path criteria apply to this change.

Note for reviewers (not counted as a finding). Turning on source-control also turns on its hooks (hooks.json) for every session that loads this repo's project settings:

  • the PR-body linkage gate on gh pr create/edit and on the GitHub MCP create/update calls;
  • the git worktree add containment gate and claim;
  • WorktreeCreate and WorktreeRemove hooks that place worktrees under an external root. When nothing else is configured, that root is CLAUDE_PLUGIN_DATA.

This is how the plugin is meant to work and fits the AGENTS.md instructions the PR cites. The PR body doesn't mention these hooks, though, so it is worth knowing that worktree creation and PR-body checks change for sessions in this repo, including subagents started with worktree isolation.

Spend (no hold). Each new key adds one project-scope install record per checkout at local session start, and the two plugins' skills take a share of the skill-listing budget. This uses subscription usage only and starts no billed resource.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit a0248d0 Nov 16, 2026
80 checks passed
@kyle-sexton
kyle-sexton deleted the chore/enable-instructed-plugins branch November 16, 2026 19:26
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant