Repository navigation
chore(settings): enable source-control and app-control for this repo - #16607
Conversation
AGENTS.md tells every session to open and ready pull requests with /source-control:pull-request and to drive skills with /app-control:drive, but .claude/settings.json did not enable either plugin. Enable both, keeping the keys in byte order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #16607 (head 54eac80)I read the full diff (1 file, Change: two keys are added to the project's What I checked:
Spend: each enabled key writes one project-scope plugin install record per checkout when a local session starts. That costs no money and is not a hold. Embedded text: none. The PR context contains no instructions aimed at this lane. Result: no security issues found. critical-findings: 0 |
|
claude-review reviewed Code review: PR #16607, enable source-control and app-control in
|
No related issue: owner decision to enable in the repository settings the plugins this repository's own instructions tell every session to use.
session: AI Hero
Summary
AGENTS.mdtells every session to open and ready pull requests with/source-control:pull-request(lines 5, 10, 68, 71, 78, 79) and to drive skills with/app-control:drive(line 130)..claude/settings.jsondid not enable either plugin. This PR enables both.Slash names found in the instruction files (
grep -oE '/[a-z-]+:[a-z-]+'overAGENTS.md,CLAUDE.mdand.claude/rules/):/source-control:pull-requestAGENTS.md, always loaded/app-control:driveAGENTS.md, always loaded/evals:design.claude/rules/eval-case-transcripts.md, path-scoped/docs-hygiene:rename-references.claude/rules/skill-bodies-state-current-rules.md, path-scoped/session-flow:workflowFix
.claude/settings.json: addapp-control@melodic-software: trueandsource-control@melodic-software: truetoenabledPlugins, in byte order. Nothing else changes.scripts/check-plugin-catalog-enablement.sh:18-20): each enabled key writes one project-scope install record per checkout on local session start. Two keys add two records.Marketplace resolution for a fresh clone: not changed
A fresh clone resolves the
melodic-softwaremarketplace in a cloud session, where.claude/cloud-bootstrap.sh:188-193registers the checkout. A local clone resolves it only through the user's own registration, because the bootstrap exits on non-cloud sessions (.claude/cloud-bootstrap.sh:40-43). On a local machine with no registration, the two new keys name an unknown marketplace and install nothing. ProjectenabledPlugins"doesn't install them" (settings reference: enabledPlugins).This PR does not add an
extraKnownMarketplaces.melodic-softwareentry. The repository forbids one on purpose:scripts/check-plugin-catalog-enablement.sh:173-183(SHADOWING) fails CI on it..claude/cloud-bootstrap.sh:127-131records that the project settings declare no marketplace.The docs confirm the mechanism. When several settings files define the same marketplace name, the highest-precedence entry is used whole (settings reference: extraKnownMarketplaces), and project settings outrank user settings (settings precedence). A project
githubentry would therefore replace contributors' own registrations and the cloud bootstrap's directory registration, so cloud sessions would serve published main instead of the branch. Changing that is left to the owner.Verification
enabledPluginsbefore (origin/mainat 9782ef1): ai-slop, animation (false), attribution, discipline, docs-naming, evals, explainer-video, gaming (false), guardrails, harness-config, harness-ops, instruction-placement, pixel-art (false), playgrounds (false), plugin-quality, retro-audio (false), skill-quality, speech.app-control@melodic-software: trueandsource-control@melodic-software: true..claude-plugin/marketplace.jsonhasname: "melodic-software"and entriesapp-control(./plugins/app-control) andsource-control(./plugins/source-control).plugins/app-control/.claude-plugin/plugin.jsonandplugins/source-control/.claude-plugin/plugin.jsongive the samenamevalues.scripts/check-plugin-catalog-enablement.shpasses: "Every enabledPlugins key for 'melodic-software' names one of the 95 catalogued plugins; none orphaned; keys sorted; .claude/cloud-bootstrap.sh installs that same marketplace."scripts/and.github/forenabledPluginsfinds the gate above, which checks key names and order, and test files that use their own fixtures. No expectation needed updating.Related
melodic-softwareregistration, should the project settings register the marketplace? Option A, recommended: keep the current behavior. A contributor runsclaude plugin marketplace add melodic-software/claude-code-pluginsonce. Option B: add anextraKnownMarketplacesgithub entry and remove the SHADOWING check. That overrides contributors' registrations and the cloud directory registration in this repository.🤖 Generated with Claude Code
https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2