Repository navigation
docs(enforcement-ladder): add the architecture and retro Selection rules rows in ladder 3.2.0 - #16602
melodic-automation-lanes[bot] wants to merge 1 commit into
Conversation
Lane-Activity: work-resolve-issue/resolve-issue
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed No security issues found. This PR changes documentation only. It bumps the enforcement-ladder contract (
critical-findings: 0 |
|
claude-review reviewed Code review: enforcement ladder 3.2.0 (Selection rules rows)No findings. This is a documentation-only change: a minor version bump of the canonical ladder, five generated copies, a CHANGELOG entry and five patch changelog fragments. What I checked against the source (read with tools):
Closing issue #16028:
Not verified (author's claims): the Embedded text: none in the PR context told the lane to approve, skip a check, or post elsewhere. No plugin manifests changed. No security-lane scope applies. Verifier dropped 0 of 0 candidates. |
There was a problem hiding this comment.
The pr-verify verifier failed head 27fe8d09c14b60b1b31c95b3500227b75e97161c. What it wrote, as data:
What it wrote (26 lines)
Summary: Issue #16028 is part 1 of #15729, covering the list and the ladder. The ladder half is done
correctly. The README moves to 3.2.0 and gains Selection rules rows for
`/architecture:enforce-boundaries` and `/session-flow:retro`. It also says that a skill with no
selection rule of its own has no row and hands the rung to `/corrections:codify`, and it names the
readers that use a copy only for the boundary list. The CHANGELOG has a 3.2.0 entry, which is a
minor bump as its own rules require. All five regenerated copies match the canonical text. There
is one changelog fragment per carrier. The diff adds no new skill (AC10) and cuts nothing (AC7).
CI on the judged head is green: Check Managed Files, Lint Repo, Check Skills, Test Bash (0) and
Test Python (0) all succeeded
(https://github.com/melodic-software/claude-code-plugins/actions/runs/43935023014). The capture
was blocked by the credit gate, which counts neither way. Two parts of the spec are not met.
First, AC12 requires every existing skill that places enforcement or an instruction to be on the
recorded list with its route. That list exists only in the pull request body, and it is visibly
cut off: it ends at `/planning:design` followed by "-…". So the list is incomplete and AC12 cannot
be confirmed. Second, the dogfooding step appears only in a side remark under "Not verified" that
refers to "the step named in the PR body", but the body never states it on its own. No secrets,
takeover-set files, holds or settings are touched. I found no text that tries to steer the
reviewer.
- PR body (Summary, "Recorded list"): the quoted list is cut off after `/planning:design` with "-…",
so it is not true that every existing enforcement- or instruction-placing skill is on the recorded
list with its route (AC12). Restore the full list in the body, or record it in a file in the
repository, so that every skill from the sweep appears with its route.
- PR body: the dogfooding step is only mentioned in passing under "Not verified" ("the step named in
the PR body"), and the body never actually states it. Add a line that names this repository's
dogfooding step, e.g. running `/harness-config:audit-automation-gaps` here after release plus
`scripts/sync-shared-copies.sh --check`.
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: docs/contracts/enforcement-ladder/README.md:201, .changes/architecture/work-resolve-issue-issue-16028-43931031836-1-c160e39a.md:1
Both points hold: the Summary's recorded list stops at /planning:design followed by a cut-off entry, and the body never states the dogfooding step on its own. Neither point can be fixed in this round. The full list cannot be recovered from the checkout: no file in the repository holds the sweep, and the cut-off entries (the rest of the presence-gated group and any groups after it) exist only in the earlier run's output. Rebuilding them would take a fresh sweep across every plugin's skills and agents, which is too much for one scoped change, and a guessed list would weaken AC12 rather than show it is met. The verifier's alternative, recording the list in a repository file, needs a new file, and check-paths refuses one (for example docs/contracts/enforcement-ladder/enforcement-placing-skills.md). Putting the sweep inside the ladder README (line 201 is where it says skills with no row hand the rung to codify) would add a per-repository inventory to a contract that is copied into five plugins. That is a design decision for a person. A body-only edit cannot carry a fix in this mode. A person should restore the full list, either in the body or in a file they choose, and add a line naming the dogfooding step, for example running /harness-config:audit-automation-gaps in this repository after release plus scripts/sync-shared-copies.sh --check.
Lane run report
Failed GitHub API calls
|
|
pr-unblock / address-feedback finished round 1 of max 4 on 27fe8d0. |
Lane run report
Failed GitHub API calls
|
|
The pr-unblock lane stopped
When a retry on this head can change the outcome, the lane runs one on its own, up to its per-head cap, and edits this comment if it stops again; a run that does not stop clears the status. When no retry can (a review thread the lane does not take or settle, or a failing check after the retries are spent), a person resolves the threads or gets the checks green, then dispatches the workflow below: that run finds the cause gone and clears the status. On a pull request the lanes App opened, the dispatchers start that run once per stop; on any other, a person does. A new commit to the branch starts clean. To run it again on this head now, dispatch the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=16602 -f activity=address-feedback |
Closes #16028
Summary
Opened by the work-resolve-issue lane. The run's own summary:
Not verified
Fix
/architecture:enforce-boundariesand/session-flow:retrorows, "Neither skill" becomes "No reader", and a paragraph says a skill with no selection rule of its own has no row and hands the rung to…Verification
The runner ran each check from the base copy against 27fe8d0:
The run reports:
## Selection rules, so the new rows add no rung idsLeft out: the items under Not verified.
Related
#16028