Skip to content

feat(fleet): start a relay session in the target lane's plugin profile - #16601

Merged
kyle-sexton merged 3 commits into
mainfrom
feat/16541-reach-relay-profile
Nov 16, 2026
Merged

kyle-sexton merged 3 commits into
mainfrom
feat/16541-reach-relay-profile

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Closes #16541

Summary

A session that /fleet:reach or its relay starts on a WSL lane can now start in that lane's plugin profile, the way local launch sites do since #16523. The reach skill's prompt line also says to name the session that holds a PR, issue or branch, and never to tell the target to take the work over on its own judgment (added scope, owner decision Q4).

Fix

  • plugins/fleet/skills/reach/reference/relay.md: new section "Start in the target's plugin profile". It finds the target's profiles.mjs by running claude plugin list --json on the target and taking the installPath of the enabled plugin-profiles@… entry, as find_profiles_script in lane-launcher.sh does (owner decision, issue comment; FLEET.md renders no path). It runs launch <profile> --folder <dir> --unattended --json there with the verb's own --settings JSON in --with, and starts the session with the printed command. A Verified-behavior row marks it untested on a live hop.
  • plugins/fleet/skills/reach/SKILL.md: a "Start in a profile" bullet pointing at that section, and the one added sentence on the prompt line.
  • Windows lanes (R1, R3, R6) stay on today's start and say the profile was not applied: the printed command is a POSIX env -u … claude line (profiles.mjs launch, argv built at scripts/profiles.mjs:425). Basis: judgment; the issue names no Windows lane.

Done-when, item by item:

  • The relay reference has one section for starting the target session in a profile: runs profiles.mjs launch on the target (path found through claude plugin list --json, per the decision that replaces "path from FLEET.md"), merges the relay's settings through --with, starts claude with the printed command.
  • With no profile named, or where plugin-profiles is not installed and enabled, the relay starts as today and says the profile was not applied.
  • An unattended start whose profile needs a missing required tool stops and reports: every relay start passes --unattended; on exit 1 nothing starts and the printed reason is reported.
  • Tests cover the profile and no-profile paths: eval cases reach-start-in-profile and reach-start-without-profile, each deterministic grader with pass and fail samples.

Not delivered

  • Windows lanes (R1, R3, R6) start without the profile: the relay starts them as today and says the profile was not applied.
  • The new section is untested on a live hop: no relay session has yet been started in a profile on a real target.

Verification

  • python3 plugins/evals/skills/validate/scripts/validate-cases.py plugins/fleet/evals: exit 0; both new cases' regex and tool_used graders accept every pass sample and reject every fail sample. The two WARNs are on existing cases.
  • markdownlint-cli2 on the changed markdown: 0 issues.
  • The eval cases themselves (model runs) were not run here; the plugin-evals lane runs them.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_015XWwmchG8Tg8XKYxMrgKKq

kyle-sexton and others added 2 commits November 16, 2026 13:48
The relay finds the target's profiles.mjs through claude plugin list --json,
runs launch --unattended there with its own settings in --with, and starts
claude with the printed command. With no profile named, no plugin-profiles on
the target, or a Windows lane, it starts as before and says the profile was not
applied. The prompt line also says to name the session that holds a PR, issue
or branch, and never to tell the target to take the work over on its own.

Closes #16541

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015XWwmchG8Tg8XKYxMrgKKq
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 18:52
@kyle-sexton

Copy link
Copy Markdown
Member Author

Owner: the session plugin-profiles-build-6, working for the control-hub session "Plugin Presets". Ready steps: branch updated by merging main (head 508de53); code and security review left to their CI lanes (both healthy); tests run locally (eval-suite validator exit 0, markdownlint 0 issues, pre-push check-affected passed). Review findings go through Plugin Presets.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T18:54:59.748578Z 508de53 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 508de53951

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/fix-docs
Model rung 0
Leg handoff
Run job success
Activity step success
Commits pushed none (read lane)
Run 43933465969

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed bbff8c72bff8e244fb68270db4cf2e94c2de95d1: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #16601 (incremental, 508de53 to bbff8c7)

I found no security issues. This lane already reviewed an earlier head, so this pass reports blocking findings only (CRITICAL and IMPORTANT).

What I read. There is one file in scope, plugins/fleet/skills/reach/reference/relay.md, and I read its single hunk. It matches no trusted-path glob, and it is not a plugin manifest, workflow, action, hold script or trust control.

What I checked.

  • Old wording: pass the verb's --settings JSON in --with, "since claude keeps only the last --settings".
  • New wording: pass it there "so the started session carries one settings file (profiles.mjs merges it into the profile's)".
  • What still holds: the command block is unchanged, and so are the crossSessionInbound: accept value and the --unattended flag.
  • Conclusion:
    • The edit changes only the stated reason.
    • It grants no new setting or access, and no new input reaches the command.
    • It deletes, narrows or softens no standing instruction, so nothing is due under the instruction-surface lens.

Spend. This change can cause no charge.

critical-findings: 0

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude-review: 1 inline finding(s) on 508de539511dfac2a6089b94262d0e9ddd125a2c; the summary is in this lane's pull request comment.

claude-lane: claude-review

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed bbff8c72bff8e244fb68270db4cf2e94c2de95d1: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Incremental review: 508de53 → bbff8c7

This was a blocking-only review, because this lane already reviewed an earlier head. In scope was one file, plugins/fleet/skills/reach/reference/relay.md, and I read its whole hunk.

What changed: step 2 of the profile-launch steps no longer says "since claude keeps only the last --settings". It now gives our own reason: the verb's --settings JSON goes in --with "so the started session carries one settings file (profiles.mjs merges it into the profile's)". This fixes the earlier advisory finding under .claude/rules/skill-bodies-state-current-rules.md. The owner resolved that thread, and the new line no longer restates upstream CLI behavior.

Checked against the code (read, not run): the new claim matches launch in profiles.mjs:436-454:

  • The --with document is the base that the profile's enabledPlugins, skillOverrides and env are merged over.
  • The merged document is written to one session file.
  • Only that file is passed as --settings.

With no profile, the --with JSON is passed as the single --settings by itself, which still fits the "one settings file" wording.

Settled and prior items: the earlier finding is settled, with lines changed since resolution: no, and the fix in this push resolves it. I am not raising it again. No new candidates came up.

The PR context, settled-threads and prior-findings files contain no instructions aimed at the lane.

No verifier subagent was run on this one-line change. Verifier dropped 0 of 0 candidates.

…s our own reason

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015XWwmchG8Tg8XKYxMrgKKq
@kyle-sexton

Copy link
Copy Markdown
Member Author

On pr-verify's note that this covers WSL lanes only: decided by the hub session "Plugin Presets", and reported to the owner. The Windows-lane route is filed as #16605 and is built next, so this pull request merges with the WSL route alone. The section stays marked untested on a live hop until a profile start is run on a real target.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit a87111f Nov 16, 2026
67 checks passed
@kyle-sexton
kyle-sexton deleted the feat/16541-reach-relay-profile branch November 16, 2026 19:27
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start a fleet reach or relay session in the target lane's plugin profile

1 participant