Skip to content

ci(review): count PR 16458's one-line sany.out as generated data - #16581

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/review-generated-data-sany-out
Nov 16, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/review-generated-data-sany-out

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: #16458

Summary

Lists plugins/formal-verification/skills/chart/scripts/test/corpus/PickWorker/sany.out in scripts/review-generated-data.txt, so both hosted review lanes count it as read on PR #16458.

Fix

Both review lanes failed PR #16458 as partial (run https://github.com/melodic-software/claude-code-plugins/actions/runs/43909503487): "no Read showed the whole change of 1 listed file(s): plugins/formal-verification/skills/chart/scripts/test/corpus/PickWorker/sany.out". The file is one line of about 110k tokens of TLA+ SANY parser output, so no Read can show it whole. The lanes read this list at the merge base, so it has to be on main before #16458's review can pass.

Verification

The diff is one added path, in the format the file's header gives.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01MWmASP1SzT1TZPQp8TTQf6

The review lanes mark PR 16458 partial because no Read can show
test/corpus/PickWorker/sany.out whole: it is one line of about 110k
tokens of TLA+ SANY parser output. List it until the commit that adds
it lands, then remove it, as the file's header says.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MWmASP1SzT1TZPQp8TTQf6
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T17:44:58.414378Z 97ea71f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 97ea71fa9cfdff2a2ef84567fb36aeca04dd631b: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #16581

I read the whole diff: one line added to scripts/review-generated-data.txt. I found no security issues.

What changed. The PR adds plugins/formal-verification/skills/chart/scripts/test/corpus/PickWorker/sany.out to the generated-data list. Both hosted review lanes pass this list to ci-workflows as generated-data: (pr-review-hosted.yml#L371, pr-review-security-hosted.yml#L370). A listed file then counts as read without the lanes reading it.

Trust-boundary check.

  • Scope. The exemption covers one exact path, not a glob. It points at a test-corpus output file (.out, TLA+ SANY parser output) in a plugin that is not on main yet: plugins/formal-verification/ is absent at this head and arrives with feat(formal-verification): add the chart and setup skills and the formal-area contract #16458.
  • Where the list is read. The lanes read it at the merge base, so a PR cannot exempt its own files. It takes effect only once this PR is on main.
  • Header rules. The file's header says the loader checks a listed file's structure only, and that the path must be removed once the adding commit is on main. After that, later edits get a full review. The PR description commits to that removal as a follow-up.
  • What it does not touch. The change widens no trusted-actor list, token scope or kill switch. It grants no lane new input, and it touches no merge-hold script.
  • What it does weaken. It narrows review coverage for one data file, which is not executable code. No path reaches a leak, compromise or charge. Under the owner's throughput-phase threat model, where the only actors are the owner, its bots, its agents and its Apps, there is no attacker who reaches this path.

Residual note (not a finding). While the line stays listed, any PR that changes that exact path skips content review for it. The header and the PR's follow-up both bound this.

The PR context contains no embedded instructions aimed at the lane. No plugin manifests changed. Prior findings: none; this is the first review (blocking only: no).

critical-findings: 0

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 97ea71fa9cfdff2a2ef84567fb36aeca04dd631b: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code review: PR #16581

I found nothing to block or flag.

The change adds one path, plugins/formal-verification/skills/chart/scripts/test/corpus/PickWorker/sany.out, to scripts/review-generated-data.txt. The entry follows the file's header format: one repo-relative path per line, with no leading #. It matches the path the PR description quotes from the failed partial-review run. The description says the line will be removed in a follow-up once #16458 merges. That is the lifecycle the header asks for ("removed once that commit is on main").

Notes, not findings:

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 151a7b0 Nov 16, 2026
46 checks passed
@kyle-sexton
kyle-sexton deleted the ci/review-generated-data-sany-out branch November 16, 2026 17:58
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant