Skip to content

feat(autonomy): add whole-map-live-verification routine class - #16573

Merged
melodic-automation-lanes[bot] merged 1 commit into
mainfrom
work-resolve-issue/issue-16570-43911289634-1
Nov 16, 2026
Merged

melodic-automation-lanes[bot] merged 1 commit into
mainfrom
work-resolve-issue/issue-16570-43911289634-1

Conversation

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor

Closes #16570

Summary

Opened by the work-resolve-issue lane. The run's own summary:

Adds a whole-map-live-verification row to the autonomy routines catalog under Code quality / knowledge (AGT, R + WI, repo, C1, join: proven recurring manual pattern), next to its closest sibling control-skill-upkeep. Adds a Class parameters bullet: the pass is /testing:run-e2e map (once the testing skill has the map scope that sibling parts of #15649 add), a person starts each run, the class sets no default schedule and a consumer may give it any cadence, the driver sets isolation as for control-skill-upkeep, and no routines/ leaf is written until a consumer records a manual run. The bullet's wording follows the control-skill-upkeep sibling.

Not verified

  • tidy ran passes 4 and 5 only (markdown-only change; passes 1-3 are for code and had nothing to do). The ai-slop detector, digest guard and semantic-diff verifier could not run because this lane's Bash allows only the named wrappers, so the ai-slop pass was a manual check against the configured…
  • the review-venue.txt file was absent, so the review ran locally in a fresh-context subagent instead of in the CI code-review lane
  • CI-only checks (lychee, vocabulary, purged-em-dashes, editorconfig and the others check-affected lists) are left to the PR's CI
  • the changes are left uncommitted in the working tree for the runner to patch, as the lane's system prompt instructs (in place of the commit step in ci-mode)

Fix

  • plugins/autonomy/reference/routines.md: new catalog row whole-map-live-verification and its Class parameters bullet
  • .changes/autonomy/work-resolve-issue-issue-16570-43911289634-1-c0463807.md: minor changelog fragment (### Added) for the new routine class

Verification

The runner ran each check from the base copy against 955e0ed:

  • scripts/check-changelog-fragments.sh --check: passed
  • scripts/check-changed-skills.sh --merge-base: passed

The run reports:

  • check-changelog-fragments: all 8 fragments valid (first run failed on a missing ### section, fixed)
  • check-changed-skills: no changed skills, nothing to gate
  • check-affected: 14 passed, 7 skipped, 0 failed over 2 changed files
  • fresh-context review subagent: no blocking findings; fixed three (map scope stated as not yet built, 'starts by hand' scoped so it does not forbid a later cadence, isolation pointer added); a fourth (singular 'a manual run' vs 'recurring' join trigger) left as is because it matches the…
  • grep for other copies of the catalog: rotating-quality-improver appears only in routines.md, so no other list needed the new class
  • The lane run: https://github.com/melodic-software/claude-code-plugins/actions/runs/43911289634

Left out: the items under Not verified.

Related

#16570

Lane-Activity: work-resolve-issue/resolve-issue
@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 955e0ed3f0ba07165fe8ed87e193dee48fbfbf70: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Security review: no security issues found.

I read both changed files in full:

  • plugins/autonomy/reference/routines.md: adds one catalog row, whole-map-live-verification (AGT, R + WI, repo, C1), and one Class parameters bullet. The bullet says a person starts each run of /testing:run-e2e map, the class sets no default schedule, and no routines/ leaf is written yet.
  • .changes/autonomy/work-resolve-issue-issue-16570-43911289634-1-c0463807.md: a new changelog fragment.

Why there is no security surface:

  • Nothing executable changed. The diff touches no plugin manifest, userConfig key, hook, workflow or script.
  • No trusted path was touched, and no trust control was widened.
  • No instruction was weakened. The diff only adds text. The new bullet keeps the class manual, with no default cadence and no leaf until someone records a manual run, so it does not remove or soften any guardrail.
  • Nothing new reaches a credentialed lane. The bullet names no tool grant or credential scope, and it passes no untrusted input anywhere.

The change matches the done-when of issue #16570. The PR context contains no embedded directives aimed at this lane.

Spend: none. The class sets no schedule, so it adds no lane runs.

critical-findings: 0

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 955e0ed3f0ba07165fe8ed87e193dee48fbfbf70: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Code review: PR #16573, the whole-map-live-verification routine class

I found nothing that needs a change. I read both changed files in full: plugins/autonomy/reference/routines.md and the new changelog fragment under .changes/autonomy/.

Closing issue #16570, its "Done when" criterion: met.

  • Catalog row. The row sits at plugins/autonomy/reference/routines.md:248 under Code quality / knowledge, next to control-skill-upkeep. Its cells match the issue exactly: AGT | R + WI | repo | C1 | join: proven recurring manual pattern.
  • Class parameters bullet. The bullet at lines 359-365 covers every point the issue asks for:
    • the pass is /testing:run-e2e map;
    • a person starts each run;
    • the class sets no default schedule, and the consumer picks any cadence;
    • no routines/ leaf is written until a consumer records a manual run.
  • Test coverage. No test guards the row's text. This is a prose reference catalog that no script reads; I grepped the repo and found none. A missing test here is not a real gap, so I did not count it as a finding.

Consistency checks

  • Existing wording. The bullet copies the wording and structure of the control-skill-upkeep bullet just above it. It points to that bullet for isolation instead of repeating the cloud-setup text, which keeps it short.
  • The map scope does not exist yet. plugins/testing/skills/run-e2e/SKILL.md has no map scope today. The bullet makes the pass conditional on the skill having it, and the PR body says sibling parts of Run a whole-map live verification pass on demand and report what is new since the last pass #15649 will add it. So the catalog does not claim something that is not there.
  • Leaf count. The class's status is join, not v1, so the "eleven v1 classes" count in the v1 leaves section is unaffected.
  • Changelog fragment. bump: minor with an ### Added entry fits a new catalog class under semver.
  • Plugin manifests. The PR changes no plugin.json or marketplace.json, so there are no manifest lines.

Not checked by me: the PR body reports that check-changelog-fragments and check-changed-skills passed. I had no shell to run them, so those results are the author's claim and unverified.

Text addressed to the review lane: none in the PR context.

Verifier dropped 0 of 0 candidates.

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

The unattended merge path armed native auto-merge at head 955e0ed3f0ba07165fe8ed87e193dee48fbfbf70, the head its arming checks judged.

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

Verification evidence for 955e0ed

The verifier passed this head. The capture artifact holds the capture summary, which says whether the capture ran, and any screenshot or video that passed the mask check; this comment uploads no file.

Capture artifact: pr-capture-16573-955e0ed3f0ba07165fe8ed87e193dee48fbfbf70, expires on 2026-12-16.

One comment per pull request, updated in place for each new head.

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

Merge-Risk: max=LOW demote=false head=955e0ed3f0ba07165fe8ed87e193dee48fbfbf70 rubric=10.0.0 rater=claude-opus-5-5 checker=claude-opus-5-5

@melodic-automation-lanes
melodic-automation-lanes Bot added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 49be155 Nov 16, 2026
49 checks passed
@melodic-automation-lanes
melodic-automation-lanes Bot deleted the work-resolve-issue/issue-16570-43911289634-1 branch November 16, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run a whole-map live verification pass on demand and report what is new since the last pass - part 5 of 6

0 participants