Skip to content

fix(session-flow): point the retro skill at its context files so they resolve from the skill directory - #16565

Merged
kyle-sexton merged 2 commits into
mainfrom
fix/16368-retro-context-paths-resolve-from-skill-dir
Nov 16, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
fix/16368-retro-context-paths-resolve-from-skill-dir

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Closes #16368

Summary

/session-flow:retro named its mode files context/session.md and context/quick.md as bare backtick paths, and its "Spoke paths" note called them "the context/ files" next to <plugin-root>. Eval runs read that as <plugin-root>/context/session.md, got "File does not exist", then globbed the plugin root, which is always denied. Every mention is now a relative Markdown link, and "Spoke paths" says the files sit beside the skill's own SKILL.md.

Fix

  • plugins/session-flow/skills/retro/SKILL.md: the six context/ mentions (mode table, Session settings, Multi-session awareness, Spoke paths, Next) are relative links, the form the file already uses for reference/.
  • .changes/session-flow/: patch changelog fragment.

Verification

Tests, on the head after merging main:

  • plugins/skill-quality/scripts/check-skill.sh retro (the /skill-quality:check gate): PASS, 0 errors, 5 warnings, none about the changed lines; its script test scripts/parse-transcript.test.sh passed.
  • pytest plugins/session-flow/skills/retro/scripts/test_parse_transcript.py: 45 passed.
  • Every context/ mention in retro/SKILL.md is a link (lines 66, 67, 107, 126, 193, 207).

Eval record (pre-registered before any launch; one run of each batch, no reruns or rescoring):

  • Case re-mechanical-finding-check-proposal (the retro case with the most plugin-root Glob denials in an earlier eval: 7 of 12 Sonnet runs, both sides carrying the defect).
  • claude plugin eval, Claude Code 2.1.325, --model sonnet, judge claude-opus-5-5, 6 runs a side. BEFORE = merge base ad1c8576af6977687c604e784dabb424f06440a4; AFTER = be44a15353f16cf9604e0fd0ca2bbe15c03e23b7. Both copies carry the same evals/ tree; they differ only in skills/retro/SKILL.md.
  • Measure: launched runs whose trace holds a denied Read, Grep or Glob at or under that side's plugin root.
BEFORE AFTER
Launched / reached the skill 6 / 6 6 / 6
Plugin-root denial runs 1 (run 2: Glob of the plugin root) 0
hands-off-to-codify 6/6 6/6
check-not-prose-rule 5/6 6/6
no-early-codify 6/6 6/6
no-write 6/6 6/6
no-edit 6/6 6/6
no-bash-writes 6/6 6/6
Cost USD 1.7148 1.6116

Pass rules, fixed before launch: M1 both result files present with 6 launched runs each, neither void; M2 AFTER plugin-root runs = 0; M3 at least 5 AFTER runs reached the skill; M4 each grader passes in at least 5 of 6 launched AFTER runs; M5 no recorded stop. All five met: verdict MET. Total cost 3.3264 USD (judge cost included).

The BEFORE side denied in 1 of 6 runs, below the 4 of 6 the earlier eval saw for this case, so 1 against 0 is a small sample difference; the done-when bar (no AFTER-side plugin-root denial) is met.

Amendment to the launch path, recorded before any launch: the launch PATH filter strips mise's shim folder, and on the host node existed only as that shim. Retro session mode runs node "<plugin-root>/skills/setup/scripts/setup-apply.mjs" --check, and the registration voids a result file on command not found for node, which would have failed M1 for a setup reason. The filter gained one line appending the node install folder at the end of PATH. No launch line, pass rule, bar, run count, exclusion, cap or eval flag changed.

Main merged into the branch after the eval (git merge, no conflict). In the measured paths (plugins/session-flow, plugins/evals) main changed, between the measured head and this head:

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01MWmASMXyUAaNx5GqGM3h6c

kyle-sexton and others added 2 commits November 15, 2026 23:09
…folder

The retro skill named context/session.md and context/quick.md as bare
backtick paths, and its "Spoke paths" note called them "the context/
files" beside <plugin-root>. Eval runs read that as
<plugin-root>/context/session.md, failed, and globbed the plugin root,
which is always denied. Every mention is now a relative Markdown link,
the form this file already uses for reference/, and the note says the
files sit in the skill's own context/ folder beside SKILL.md.

Refs: #16368

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 16:42
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T16:43:32.230250Z 8cf9da3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 8cf9da36709b85cf830a107ff0bad97370bc1158: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Security review: no security issues found

I read both changed files in full:

  • plugins/session-flow/skills/retro/SKILL.md: six mentions of context/session.md and context/quick.md were bare backtick paths. They are now relative Markdown links, the same form the file already uses for reference/. The "Spoke paths" note now says these files sit beside this SKILL.md.
  • .changes/session-flow/fix-16368-...md: a new patch changelog fragment.

Instruction surface. The change removes or weakens no rules. "Spoke paths" still tells the model to replace the <plugin-root> placeholder with ${CLAUDE_PLUGIN_ROOT} before running a command or writing a brief. The edit only says where the context files are. The ${user_config.retro_lenses} line is unchanged; only the link next to it changed.

Out of scope for this change:

  • No plugin manifest, userConfig key, hook, workflow, trust control, token scope, kill switch or merge hold is touched.
  • Neither file matches a listed trusted path.
  • No untrusted text gains a new route into a credentialed lane.

PR context. The description matches the diff and contains no embedded instructions to this lane. The closing issue's body was left out by the wrapper because its author is not on the allowed list.

Prior findings. This lane had not reviewed an earlier head (blocking only: no), and there is nothing to repeat.

critical-findings: 0

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 8cf9da36709b85cf830a107ff0bad97370bc1158: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

No findings. This is a docs-only change to two files: the retro skill's SKILL.md and a patch changelog fragment.

What I checked

  • Links resolve. All six context/ mentions in plugins/session-flow/skills/retro/SKILL.md (lines 66, 67, 107, 126, 193 and 207) are now relative Markdown links. Both targets exist beside the skill: retro/context/session.md and retro/context/quick.md. I confirmed this with Grep and Glob. No bare context/ path is left.
  • "Spoke paths" reads correctly. The section still says <plugin-root> stands for ${CLAUDE_PLUGIN_ROOT}, and it now also says the context files sit beside SKILL.md. That keeps the plugin root and the skill folder separate, which is the misreading the issue describes.
  • Changelog fragment. bump: patch fits a docs fix to the skill's wording.
  • Path rules. .claude/rules/skill-bodies-state-current-rules.md covers this file. The change restates nothing from upstream and leaves ## Next before ## Gotchas. .claude/rules/cost-claims.md also matches the skill path; the changed lines make no cost claims.

Closing issue #16368, "Done when"

  • Every context/ reference is a relative link: met. I checked this myself with Grep.
  • The skill's tests and /skill-quality:check pass: author-claimed, unverified. I had no shell to run them.
  • A before/after eval with no plugin-root denial on the after side: author-claimed, unverified. The PR reports 0 denials after against 1 before over 6 runs a side. That is the author's eval record; I did not reproduce it.

No embedded instructions in the PR context. No manifest changes. The change itself spends nothing; the author's eval cost was a one-off spend of prepaid credit.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit bb5d3ad Nov 16, 2026
77 checks passed
@kyle-sexton
kyle-sexton deleted the fix/16368-retro-context-paths-resolve-from-skill-dir branch November 16, 2026 16:55
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(session-flow): point the retro skill at its context files so they resolve from the skill directory

1 participant