Repository navigation
feat(architecture): sweep citations on ADR retirement and offer a pointer comment - #16552
Conversation
…nter comment record-decision Step 3 now lists every tracked line citing the retired record's identifier or path, by file:line, and proposes pointing each at the new record or dropping it, applied in the same change behind the existing yes. It runs for every adr_retirement value and for a partial reversal. audit lists each candidate's citing lines and stays read-only. New Step 4 offers one pointer comment at the code a new record governs, written only after a yes; the citation sweep keeps it from outliving its record. The reversal and audit eval cases gain a citing line and a grader that the reply lists it by file:line. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
… unchanged Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 137c7f24f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Lane run report
Failed GitHub API calls
|
|
claude-security-review needs no new review of Security review (incremental, blocking only): no security issues foundThis was an incremental review covering the changes since
Neither file matches a trusted-path glob. The change touches no workflow, token, kill switch, merge hold or trusted-actor list, no Usage. The added grader is checked against the same eval transcripts, so at most it adds a negligible amount of prepaid model usage when evals run. This is not a billing change. Earlier posts. This lane already reviewed head critical-findings: 0 |
|
claude-review needs no new review of Code review (incremental, blocking only): PR #16552Scope: the push since
This lane already reviewed an earlier head, so this review reports blocking findings only. Result: no new findings. This push fixes my earlier finding (#16552 (comment)): the citing file was guarded against
Not verified by me: the owner's "Offline eval validator: no FAIL" is their own claim; I ran nothing. Settled threads: the owner's reply on that thread is a decision ("CORRECT … Added citing-file-not-overwritten"), and its lines have not changed since it was resolved. Nothing to raise again. Usage: one more offline grader in the eval case. It makes no extra model calls. Verifier dropped 0 of 0 candidates. |
citing-file-not-edited counted only Edit calls, so a Write over src/api/schema.graphql passed. citing-file-not-overwritten counts Write calls to that file, mirroring the old-record-not-overwritten pair. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: owner-decided change to
/architecture:record-decision, with no tracking issueSummary
Retiring an ADR left every line that cited it pointing at a record that no longer exists, is archived, or no longer holds.
/architecture:record-decisionnow finds and fixes those citations in the same change as the retirement, and offers one pointer comment at the code a new record governs.Fix
adr_retirementvalue (delete,supersede,archive) and for a partial reversal,git grep -nthe old record's identifier forms and filename across tracked files, list each hit asfile:line, and propose pointing it at the new record or dropping it. A changelog or release-note hit is listed as keep. The edits apply behind the existing yes, in the same change. An accepted record may now also be edited to repoint a citation.rd-reversal-asks-before-retiringandrd-audit-lists-gone-recordscaffolds gain a citing line, with alists-citationregex grader each and aciting-file-not-editedgrader on the reversal case, all with pass and fail samples.Verification
scripts/check-affected.sh: 17 passed, 1 skipped (ruff, no Python changed).plugins/evals/skills/validate/scripts/validate-cases.py plugins/architecture/evals: no FAIL; only existing WARN lines.check-affected, guardrails reference and content checks): passed.Related
/code-tidying:remove-comments(if enabled) is being taught separately to keep such a pointer comment; this PR does not touch that plugin.session: AI Hero
🤖 Generated with Claude Code