Repository navigation
Closed
Require preconditions and per-step evidence in control skills, and never weaken a journey to pass#15800
Feature
Copy link
Description
Parent
Refs #15659. Second of five alignment items that bring app-control closer to Lauren Tan's verification skills (cursor/plugins pstack/skills/create-verification-skill, MIT).
Depends on
- the first alignment item (drive steps state their result and end with a proof step), linked as a blocker
Outcome
A control skill states what must be true before a feature is driven and what evidence each kind of step needs, and a run never passes by weakening the journey.
Demo: a feature file's drive section opens with its preconditions; driving a feature whose seed data lacks one reports a failed step with the reason recorded in that feature's gotchas, and the steps are not edited to pass.
What her skills require, kept:
- The drive section "starts with
Preconditions:" (references/feature-map-example/README.md:39). - "If the seed data lacks a precondition that a journey needs, the journey reports a failure and the reason goes in that feature's
Gotchas. Never weaken the journey to make it pass." (create-verification-skill/SKILL.md:36). - Proof per kind of action (
references/feature-map-example/README.md:23-31): a UI step captures an accessibility snapshot and a screenshot with the app's identity visible; a command-line step records the command, standard output, standard error and exit code; a step that changes stored data adds a read-only second view of the stored value; every artifact records the feature and entry point used; a skipped entry point is never reported as verified through a different path. - A dry-run option is trusted only after it was observed to change nothing.
Decisions
- Owner, 2026-11-12: align closer with what her skill does and produces.
/verification:confirmalready holds "never weaken a user journey to make it pass" for its own live drive; this item puts the rule in the control-skill contract so creating and refreshing a control skill follow it too.- Today a failed step from a missing precondition is treated as a control-skill fault and fixed once. After this item, "the control skill is wrong" and "the data lacks the precondition" are separate cases.
- The read-back rule for stored data already exists in the end-to-end skill's context; the contract points at it and does not copy it.
- Whether the preconditions line is required by the contract check (breaking, needs a refresh) or optional is decided in the change by the evidence of how many existing features have a precondition to state; say which in the pull request.
Key interfaces
- The contract's feature file drive section and its capture kinds.
- Drive's evidence report gains exit code and standard error on a command-line step.
Done when
- The contract defines the preconditions line and the never-weaken rule, and the create and refresh flows separate a wrong control skill from missing seed data.
- The contract states the evidence each kind of step needs, pointing at the existing read-back rule.
- Drive's report records exit code and standard error for a command-line step.
- A dry-run command in a control skill is marked trusted only after an observed no-change run.
- This repository's control skills follow the new rules where they apply (dogfood), named in the pull request body.
- Changed skill text ships on a two-version compare of the changed skills' cases (
opusandsonnetaliases, three runs per side,--casefilter, a--max-cost-usdceiling, no new batch after a usage-limit error), run in the one local eval-runner session; the pull request carriesdo-not-mergeuntil the record lands.
Out of scope
- Launch and readiness rules, upkeep, hub conventions and the driver CLI (the other alignment items).
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Work status
needs-triage
Priority
medium
Activity
github-actions commentedon Nov 13, 2026
Size: Medium
Complexity: Medium
Uncertainty: Known
Flags: none
Blocked by: #15797
Understood: add a preconditions line and a "never weaken the journey" rule to the control-skill contract. Create and refresh would treat a wrong control skill and missing seed data as separate cases. The contract would also state the evidence each kind of step needs, and drive's report would gain exit code and standard error on command-line steps. A dry-run command would count as trusted only after an observed no-change run. This repository's control skills would follow the rules, and the changed skills would get a two-version eval compare.
The issue names #15797 (the first alignment item) as a blocker, so it is listed above. No duplicates found among open issues, and no merged pull request looks like it already covers this. Related alignment items: #15798, #15799, #15801.
The choice between a required and an optional preconditions line is left to the change, which the issue allows, so nothing here needs an owner decision.
Automated triage. A maintainer reviews it.
melodic-automation-lanes commentedon Nov 13, 2026
Not admitted to the issue lane yet: blocker #15797 is not closed by a listed human or a merge.
melodic-automation-lanes commentedon Nov 15, 2026
{"v":1,"actor_id":337595936,"title_sha256":"ebcb353abfdbb23890398f7cddf88029b39628813f644ce06220bf5c6b24fda8","body_sha256":"a9201636665e524a74444004d93cd7df7fca67b4ff37bcf3e8036216685900ff"}
github-actions commentedon Nov 15, 2026