Skip to content

fix(review): a -diff lockfile makes both review lanes fail as partial #1109

Closed as not planned

Description

@kyle-sexton

Both hosted review lanes fail any pull request that adds or changes a package-lock.json. The fail class is partial: the publish step counts the lockfile as a binary file it cannot review, so it reports the head as not reviewed. The PR stays red on both review lanes whatever it contains.

Evidence

  • claude-code-plugins PR #16458, run https://github.com/melodic-software/claude-code-plugins/actions/runs/43909503487 ("PR Review / Publish Review"), and the security lane run https://github.com/melodic-software/claude-code-plugins/actions/runs/43909503423:

    ##[error]claude-review: failure-class=partial: the review read only part of the pull request, so the head is not reviewed (read 452 of 453 changed file(s); 1 binary file(s) not reviewable as text: `plugins/formal-verification/skills/chart/scripts/package-lock.json`
    
  • The file is 1,459 bytes of JSON, not binary. claude-code-plugins .gitattributes lines 37-42 mark package-lock.json, packages.lock.json and *.lock as -diff ("Lockfiles: tracked, but suppress noisy diffs"). With -diff, git prints Binary files differ for them, and .github/actions/publish-review/publish.cjs counts that as an unreviewable binary.

Done when

  • A changed file the consumer marks -diff as a lockfile (or any -diff path that is text) does not make the review partial. Either the publish step exempts it from coverage and names it in the summary as not reviewed by design, or the review reads it with --text.
  • A test in .github/scripts/publish-review.test.cjs covers a -diff lockfile beside a real binary (an image), and only the image path's rule is unchanged.
  • claude-code-plugins PR #16458's review lanes pass on a rerun after the fix is released and pinned.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 16, 2026
  2. kyle-sexton commented on Nov 16, 2026

    @kyle-sexton
    MemberAuthor

    Closing as not planned: the hub misdiagnosed it. The partial review on claude-code-plugins PR 16458 came from a one-line sany.out no Read can show whole, not from the -diff lockfile, and binary_files never fails a review by itself (publish.cjs 237-243). Fixed in claude-code-plugins PR 16581 through generated-data. PR 1110 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-triageNot yet classified. Floor until a type and one priority tier are set.

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions