Repository navigation
chore: add ecosystem records for the toolchain skills - #258
Conversation
Add .claude/ecosystems/ records for bash, markdown, yaml, typescript (the node:test drift checkers under .github/scripts/) and cross-cutting, so /toolchain:check and /toolchain:lint run the commands and versions pr-require-checks.yml and its ci-workflows composites at 594987a run, instead of the marketplace's bundled defaults. Refs: melodic-software/claude-code-plugins#15726 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d4c40cbf7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
claude-security-review needs no new review of Security review of PR #258 (head 9d4c40c): no security findings. The PR adds five new YAML records under What I checked:
I did not fan out to verifier subagents because no candidate findings survived. |
|
claude-review reviewed Incremental review of The only change is a new inventory entry in the "Agent config" bullet. It lists
Verifier dropped 0 of 0 candidates. |
The "What's here" section covers every tracked file; the five .claude/ecosystems records were missing from it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Refs: melodic-software/claude-code-plugins#15726
Summary
This repository now resolves its build, test and lint commands from its own ecosystem records instead of the toolchain plugin's bundled defaults:
.claude/ecosystems/{bash,markdown,yaml,typescript,cross-cutting}.yaml, one per ecosystem it uses. Each command, flag and pinned version follows.github/workflows/pr-require-checks.ymland the ci-workflows composites it pins at594987a(v0.39.8). The only other change is the README inventory line that lists them. The repository has no Python, PowerShell, .NET or Go, so it gets no record for those: no tracked file matches their bundled globs.Fix
Each intended difference from toolchain's bundled defaults (
plugins/toolchain/reference/ecosystems/in claude-code-plugins), with the rule source in this repository:check-cmdisshellcheck --rcfile="$REPO_ROOT/.shellcheckrc" <files>, dropping-x -S warningandshfmt -d;test-cmdstays null;tool-pinshellcheck 0.11.0pr-require-checks.yml:294-307; shellcheck compositerun.sh:172-176passes--rcfileand omits--severity,action.yml:66pins 0.11.0;.shellcheckrcsetsexternal-sources=true, the-xequivalent. CI runs no shfmt and no shell testscheck-cmd/fix-cmdcallmarkdownlint-cli2 --config "$REPO_ROOT/.markdownlint-cli2.jsonc" <files>from PATH (bundlednpx markdownlint-cli2 <files>);tool-pin0.23.2pr-require-checks.yml:89-102; markdownlint compositeaction.yml:24(0.23.2) and:57(npx --yes markdownlint-cli2@$VERSION --config "$CONFIG")check-cmdrunsactionlintplus every check-jsonschema call of CI's jsonschema lane:vendor.dependabot,vendor.github-workflows,vendor.github-issue-forms(the forms CI's roster step derives),vendor.github-issue-config, and--schemafile https://json.schemastore.org/claude-code-settings.jsonon.claude/settings.json. Globs add.claude/settings.json. Pins actionlint 1.7.12, check-jsonschema 0.38.2pr-require-checks.yml:198-209,:211-285(roster:238-265); actionlint compositeaction.yml:20, check-jsonschema compositeaction.yml:39*.mjsand*.jsonly (bundled addspackage.json, lockfiles,tsconfig*.json);project-discovery: [];test-cmdisnode --test .github/scripts/pr-section-drift.test.mjs .github/scripts/issue-form-drift.test.mjs; build and check nullpr-require-checks.yml:340and:362. Nopackage.json, tsconfig or JS linter config is tracked, and CI lints no JavaScripttypos --config _typos.toml ., then the hidden tracked files by name;gitleaks dir . --config .gitleaks.toml --no-banner --redact(bundledgitleaks detect --no-git);"$EC_BIN" -config .editorconfig-checker.json;lychee --offline --no-progress --config lychee.tomlover CI's three globs. Every check runs and any failure fails the command. Pins typos 1.50.3, gitleaks 8.30.1, editorconfig-checker 4.0.2, lychee 0.24.2pr-require-checks.yml:104-196(hidden-path typos step:118-141, lychee globs:193-196); composites: typosaction.yml:46, gitleaksaction.yml:50withscan.sh:136, editorconfig-checkeraction.yml:35, lychee-offlineaction.yml:19enabled,project-discovery: [],gates: [],nullfor each absent command);anchoromittedWhere a record differs from CI on purpose:
npx --yes markdownlint-cli2@0.23.2over every**/*.md. The record runs the PATH binary over the changed files, so a local run never downloads; the pin warns on drift.pr-require-checks.yml:309-320) has no record command: the composite re-stages the whole index withgit add --renormalize, which is not read-only on a working tree.bash .cursor/check.shruns a safe copy.node .github/scripts/pr-section-drift.mjs,node .github/scripts/issue-form-drift.mjs) are not run, since CI does not gate on them; their test files are the typescripttest-cmd. CI runs each test file in its own lane, the record runs both in one call.ubuntu-latestimage, which this repository does not pin, so typescript has notool-pin..cursor/install.shpins older typos, editorconfig-checker and check-jsonschema versions (its "v0.29.1" authority); the records follow the composites CI calls now.Verification
Range.
9e784beccaf54aca24eaae3720ab591587a27712(#236, excluded) tobbe1ebed2f09ee088f91e947fd1db8a3038f00cf(#238): 2 first-parent commits, #237 and #238, 13 files. It is the smallest merged window that touches every ecosystem the repository has:.sh:.cursor/check.sh.mjs:.github/scripts/issue-form-drift.mjsand its test.githubYAML: four issue forms and two workflows.github/PULL_REQUEST_TEMPLATE.md,README.md,docs/standards/issue-tracker.md.github/standards/issue-body-contract/contract.json, claimed by no ecosystemMethod. A throwaway
git clone --sharedin the worktree's gitignored.work/, on a branch atbbe1ebewithrefs/remotes/origin/mainandorigin/HEADset to9e784be, so the skills' branch-diff detection yields exactly the range. For the record runs the records were copied in and hidden through the clone's.git/info/exclude;diff -ragainst this branch's records printed nothing. Every command ran asenv -C <clone> <command>. No install ran: there is no lockfile. Toolchain plugin 1.4.0./toolchain:check all/toolchain:lint/toolchain:check all/toolchain:lintNo run has a
skip (unresolvedcell. Run 3's recorded table:Baseline command lists (bundled defaults).
Record command lists (runs 3 and 4).
$Ris the clone root.The two lists differ only as the Fix table lists: the typescript test added, the scoped
--rcfile/--configarguments, shfmt dropped, the CI jsonschema calls added, the hidden-file typos pass,gitleaks dirand CI's lychee globs. The yaml and cross-cuttingcheck-cmdblock scalars ran whole, under bash and again under zsh, both exit 0.Installed versions that differ from the pins: markdownlint-cli2 0.24.0 (pin 0.23.2), typos 1.52.2 (1.50.3), editorconfig-checker 3.11.1 (4.0.2), check-jsonschema 0.39.0 (0.38.2). shellcheck 0.11.0, gitleaks 8.30.1, lychee 0.24.2 and actionlint 1.7.12 match. No drift changed a result.
Schema.
check-jsonschema --schemafile ecosystem.schema.json(claude-code-pluginsmain, blob26f92e2) over all five files:ok -- validation done. Every key was also checked by hand against the schema'sproperties. typos, editorconfig-checker and gitleaks are clean on the new files; the lefthook pre-commit and commit-msg hooks passed.Related
.cursor/install.shpins tool versions older than the composites CI calls.🤖 Generated with Claude Code