Skip to content

chore: add ecosystem records for the toolchain skills - #258

Merged
kyle-sexton merged 2 commits into
mainfrom
chore/ecosystem-records-15726
Nov 16, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
chore/ecosystem-records-15726

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Refs: melodic-software/claude-code-plugins#15726

Summary

This repository now resolves its build, test and lint commands from its own ecosystem records instead of the toolchain plugin's bundled defaults: .claude/ecosystems/{bash,markdown,yaml,typescript,cross-cutting}.yaml, one per ecosystem it uses. Each command, flag and pinned version follows .github/workflows/pr-require-checks.yml and the ci-workflows composites it pins at 594987a (v0.39.8). The only other change is the README inventory line that lists them. The repository has no Python, PowerShell, .NET or Go, so it gets no record for those: no tracked file matches their bundled globs.

Fix

Each intended difference from toolchain's bundled defaults (plugins/toolchain/reference/ecosystems/ in claude-code-plugins), with the rule source in this repository:

Ecosystem Difference from the bundled default Rule source
bash check-cmd is shellcheck --rcfile="$REPO_ROOT/.shellcheckrc" <files>, dropping -x -S warning and shfmt -d; test-cmd stays null; tool-pin shellcheck 0.11.0 pr-require-checks.yml:294-307; shellcheck composite run.sh:172-176 passes --rcfile and omits --severity, action.yml:66 pins 0.11.0; .shellcheckrc sets external-sources=true, the -x equivalent. CI runs no shfmt and no shell tests
markdown check-cmd/fix-cmd call markdownlint-cli2 --config "$REPO_ROOT/.markdownlint-cli2.jsonc" <files> from PATH (bundled npx markdownlint-cli2 <files>); tool-pin 0.23.2 pr-require-checks.yml:89-102; markdownlint composite action.yml:24 (0.23.2) and :57 (npx --yes markdownlint-cli2@$VERSION --config "$CONFIG")
yaml check-cmd runs actionlint plus every check-jsonschema call of CI's jsonschema lane: vendor.dependabot, vendor.github-workflows, vendor.github-issue-forms (the forms CI's roster step derives), vendor.github-issue-config, and --schemafile https://json.schemastore.org/claude-code-settings.json on .claude/settings.json. Globs add .claude/settings.json. Pins actionlint 1.7.12, check-jsonschema 0.38.2 pr-require-checks.yml:198-209, :211-285 (roster :238-265); actionlint composite action.yml:20, check-jsonschema composite action.yml:39
typescript Globs are *.mjs and *.js only (bundled adds package.json, lockfiles, tsconfig*.json); project-discovery: []; test-cmd is node --test .github/scripts/pr-section-drift.test.mjs .github/scripts/issue-form-drift.test.mjs; build and check null pr-require-checks.yml:340 and :362. No package.json, tsconfig or JS linter config is tracked, and CI lints no JavaScript
cross-cutting typos --config _typos.toml ., then the hidden tracked files by name; gitleaks dir . --config .gitleaks.toml --no-banner --redact (bundled gitleaks detect --no-git); "$EC_BIN" -config .editorconfig-checker.json; lychee --offline --no-progress --config lychee.toml over CI's three globs. Every check runs and any failure fails the command. Pins typos 1.50.3, gitleaks 8.30.1, editorconfig-checker 4.0.2, lychee 0.24.2 pr-require-checks.yml:104-196 (hidden-path typos step :118-141, lychee globs :193-196); composites: typos action.yml:46, gitleaks action.yml:50 with scan.sh:136, editorconfig-checker action.yml:35, lychee-offline action.yml:19
all five Every key set explicitly (enabled, project-discovery: [], gates: [], null for each absent command); anchor omitted the precedent of melodic-software/claude-code-proxy#394

Where a record differs from CI on purpose:

  • markdownlint: CI runs npx --yes markdownlint-cli2@0.23.2 over every **/*.md. The record runs the PATH binary over the changed files, so a local run never downloads; the pin warns on drift.
  • check-line-endings (pr-require-checks.yml:309-320) has no record command: the composite re-stages the whole index with git add --renormalize, which is not read-only on a working tree. bash .cursor/check.sh runs a safe copy.
  • The advisory drift comparisons (node .github/scripts/pr-section-drift.mjs, node .github/scripts/issue-form-drift.mjs) are not run, since CI does not gate on them; their test files are the typescript test-cmd. CI runs each test file in its own lane, the record runs both in one call.
  • CI's node comes from the ubuntu-latest image, which this repository does not pin, so typescript has no tool-pin.
  • .cursor/install.sh pins older typos, editorconfig-checker and check-jsonschema versions (its "v0.29.1" authority); the records follow the composites CI calls now.

Verification

Range. 9e784beccaf54aca24eaae3720ab591587a27712 (#236, excluded) to bbe1ebed2f09ee088f91e947fd1db8a3038f00cf (#238): 2 first-parent commits, #237 and #238, 13 files. It is the smallest merged window that touches every ecosystem the repository has:

  • .sh: .cursor/check.sh
  • .mjs: .github/scripts/issue-form-drift.mjs and its test
  • .github YAML: four issue forms and two workflows
  • markdown: .github/PULL_REQUEST_TEMPLATE.md, README.md, docs/standards/issue-tracker.md
  • JSON: .github/standards/issue-body-contract/contract.json, claimed by no ecosystem

Method. A throwaway git clone --shared in the worktree's gitignored .work/, on a branch at bbe1ebe with refs/remotes/origin/main and origin/HEAD set to 9e784be, so the skills' branch-diff detection yields exactly the range. For the record runs the records were copied in and hidden through the clone's .git/info/exclude; diff -r against this branch's records printed nothing. Every command ran as env -C <clone> <command>. No install ran: there is no lockfile. Toolchain plugin 1.4.0.

Run Skill Records Overall
1 /toolchain:check all bundled defaults PASS (3 of 3 ecosystems passed)
2 /toolchain:lint bundled defaults PASS (5 of 5 ecosystems passed)
3 /toolchain:check all this PR's records PASS (3 of 3 ecosystems passed)
4 /toolchain:lint this PR's records PASS (5 of 5 ecosystems passed)

No run has a skip (unresolved cell. Run 3's recorded table:

| Ecosystem  | Build | Test | Lint | Status |
|------------|-------|------|------|--------|
| typescript | —     | pass | —    | PASS   |
| bash       | —     | —    | pass | PASS   |
| markdown   | —     | —    | pass | PASS   |

Outside every ecosystem: .github/standards/issue-body-contract/contract.json
Overall: PASS (3 of 3 ecosystems passed)

Baseline command lists (bundled defaults).

# run 1, /toolchain:check all
dotnet, python, powershell, go: nothing ran (no project, no changed file)
typescript (selected by the two .mjs files): no package.json or tsconfig; biome/eslint opt-in unmet -> nothing ran
shellcheck -x -S warning .cursor/check.sh && shfmt -d .cursor/check.sh          # pass
npx markdownlint-cli2 <3 md>                                                     # npx resolved 0.24.1; 0 issues
record-result.mjs --skill check

# run 2, /toolchain:lint
typescript: opt-in unmet
shellcheck -x -S warning .cursor/check.sh && shfmt -d .cursor/check.sh          # pass
npx markdownlint-cli2 <3 md>                                                     # 0 issues
actionlint                                                                       # pass
typos                                                                            # pass
gitleaks detect --source . --redact --no-banner --no-git                         # no leaks
ec                                                                               # pass
lychee --offline --no-progress './**/*.md'                                       # 165 links, 0 errors
record-result.mjs --skill lint

Record command lists (runs 3 and 4). $R is the clone root.

# run 3, /toolchain:check all
node --test .github/scripts/pr-section-drift.test.mjs .github/scripts/issue-form-drift.test.mjs   # 34 tests, 34 pass
shellcheck --rcfile=$R/.shellcheckrc .cursor/check.sh                            # pass
markdownlint-cli2 --config $R/.markdownlint-cli2.jsonc <3 md>                    # 0 issues
dotnet, python, powershell, go: as in run 1
record-result.mjs --skill check

# run 4, /toolchain:lint: the bash and markdown lines above, plus
actionlint                                                                       # pass
check-jsonschema --builtin-schema vendor.dependabot .github/dependabot.yml       # ok
check-jsonschema --builtin-schema vendor.github-workflows <5 workflows>          # ok
check-jsonschema --builtin-schema vendor.github-issue-forms <4 forms>            # ok
check-jsonschema --builtin-schema vendor.github-issue-config .github/ISSUE_TEMPLATE/config.yml   # ok
check-jsonschema --schemafile https://json.schemastore.org/claude-code-settings.json .claude/settings.json   # ok
typos --config _typos.toml .  +  hidden tracked files | xargs typos --config _typos.toml          # pass
gitleaks dir . --config .gitleaks.toml --no-banner --redact                      # no leaks
ec -config .editorconfig-checker.json                                            # pass
lychee --offline --no-progress --config lychee.toml '**/*.md' '.claude/**/*.md' '.github/**/*.md'   # 165 links, 0 errors
typescript: check-cmd null
record-result.mjs --skill lint

The two lists differ only as the Fix table lists: the typescript test added, the scoped --rcfile/--config arguments, shfmt dropped, the CI jsonschema calls added, the hidden-file typos pass, gitleaks dir and CI's lychee globs. The yaml and cross-cutting check-cmd block scalars ran whole, under bash and again under zsh, both exit 0.

Installed versions that differ from the pins: markdownlint-cli2 0.24.0 (pin 0.23.2), typos 1.52.2 (1.50.3), editorconfig-checker 3.11.1 (4.0.2), check-jsonschema 0.39.0 (0.38.2). shellcheck 0.11.0, gitleaks 8.30.1, lychee 0.24.2 and actionlint 1.7.12 match. No drift changed a result.

Schema. check-jsonschema --schemafile ecosystem.schema.json (claude-code-plugins main, blob 26f92e2) over all five files: ok -- validation done. Every key was also checked by hand against the schema's properties. typos, editorconfig-checker and gitleaks are clean on the new files; the lefthook pre-commit and commit-msg hooks passed.

Related

🤖 Generated with Claude Code

Add .claude/ecosystems/ records for bash, markdown, yaml, typescript (the
node:test drift checkers under .github/scripts/) and cross-cutting, so
/toolchain:check and /toolchain:lint run the commands and versions
pr-require-checks.yml and its ci-workflows composites at 594987a run,
instead of the marketplace's bundled defaults.

Refs: melodic-software/claude-code-plugins#15726

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 04:32
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T04:33:12.407559Z 9d4c40c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9d4c40cbf7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/ecosystems/bash.yaml Resolved
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

claude-security-review needs no new review of 9bae7aeb273e42b26345e55c14f490ce95c24d0b: every file in scope matches docs-only-paths.

Security review of PR #258 (head 9d4c40c): no security findings.

The PR adds five new YAML records under .claude/ecosystems/ (bash, cross-cutting, markdown, typescript, yaml). They describe the local lint and test commands for the /toolchain:* skills. The diff is 164 lines and touches no workflow, action, token request, trusted-actor list, CODEOWNERS, .gitmodules, merge hold, kill switch or plugin manifest.

What I checked:

  • Trust controls: none of the changed paths is a trust control or a trusted path, so nothing widens who or what is trusted, no token scope changes, and no hold is weakened. critical-findings: 0.
  • Plugin manifests: no plugin.json or marketplace.json change, so there are no manifest <field> lines.
  • Instruction-surface deletions: the diff adds files only and removes no standing instruction, so that lens does not apply.
  • Command surfaces: the check-cmd, test-cmd and fix-cmd strings are static. They interpolate only $REPO_ROOT, <files> and $EC_BIN, and are consumed by the toolchain plugin. The xargs and $(git ls-files ...) pipelines read tracked file names and are not attacker-controlled beyond what any repo-tracked file already is. $EC_BIN is an operator-environment variable and is not set by the diff.
  • Network and secrets: the one network reference is the schemastore.org schema fetch for .claude/settings.json, the same fetch CI makes. The records carry no credentials. The gitleaks invocation only scans and redacts.
  • Pins: the tool versions are recorded for local installs only, and nothing here loosens a CI pin.

I did not fan out to verifier subagents because no candidate findings survived.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

claude-review reviewed 9bae7aeb273e42b26345e55c14f490ce95c24d0b: 0 finding(s), 0 as inline comments.

Incremental review of README.md since 9d4c40c: no findings.

The only change is a new inventory entry in the "Agent config" bullet. It lists .claude/ecosystems/*.yaml (bash, markdown, yaml, typescript, cross-cutting) as owned here and says each replaces the toolchain plugin's bundled commands with the ones pr-require-checks.yml runs.

  • The entry matches the PR description, which names the same five records and the same CI source.
  • It follows the README's own rule that the inventory lists what is owned here. The "owned here" claim also fits the PR, which says the records are not synced from standards.
  • The PR's "Closes" line is a Refs: link to claude-code-plugins#15726, and the context file has no closing-issue section, so there were no acceptance criteria to check.
  • I did not re-run any of the verification the PR describes. That verification is author-claimed.
  • Scope was README.md only. The ecosystem YAML files are unchanged since the last review.

Verifier dropped 0 of 0 candidates.

The "What's here" section covers every tracked file; the five
.claude/ecosystems records were missing from it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton merged commit c06003c into main Nov 16, 2026
40 of 41 checks passed
@kyle-sexton
kyle-sexton deleted the chore/ecosystem-records-15726 branch November 16, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant