Conversation
Contributor
|
87132f4 was deployed to: https://fred-pr1885.review.mdn.allizom.net/ |
caugner
force-pushed
the
external-link-whitespace
branch
from
September 10, 2026 12:20
8043d9d to
e110fe5
Compare
caugner
added this pull request to stack #1887
September 10, 2026 12:20
caugner
changed the title
caugner
force-pushed
the
external-link-whitespace
branch
from
September 10, 2026 12:49
e110fe5 to
2e7fb9e
Compare
caugner
force-pushed
the
external-link-whitespace
branch
from
September 14, 2026 15:08
2e7fb9e to
bfdee92
Compare
caugner
removed this pull request from stack #1887
September 14, 2026 15:09
caugner
changed the title
caugner
marked this pull request as ready for review
September 14, 2026 15:34
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| class="external" | ||
| target="_blank" | ||
| rel="noreferrer" | ||
| >Frontend Developer Career Path</a |
Contributor
There was a problem hiding this comment.
The trailing . is still on its own line, so this sentence renders as Frontend Developer Career Path ↗ . — a stray space before the period, and the period can still wrap onto its own line. Attach it to the closing bracket, matching the pattern used in components/advertising/server.js (>. We pride ourselves…):
>Frontend Developer Career Path</a
>.AI-generated review by Claude
caugner
added this pull request to stack #1910
September 14, 2026 15:59
Contributor
Author
|
Closing following discussion with Leo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix 14 external-link anchors by removing leading and trailing whitespace inside them.
Motivation
Prevent external-link icons from wrapping onto their own line.
Additional details
Use whitespace-free anchor formatting that Prettier preserves.
Validation: Prettier, ESLint, and Lit analysis pass.
Related issues and pull requests
Relates to #1870.