Conversation
caugner
added this pull request to stack #515
September 9, 2026 10:18
`proxyBSA` discarded the status returned by the viewed handler and always answered 201, so a request missing the `code` parameter was acknowledged as a recorded view.
caugner
force-pushed
the
pong-viewed-status
branch
from
September 16, 2026 08:38
7403e1d to
d6c0d7e
Compare
caugner
commented
Sep 16, 2026
caugner
changed the title
/pong/viewed without code/pong/viewed codes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
LeoMcA
approved these changes
Sep 17, 2026
| redirect: "manual", | ||
| }); | ||
| if (!view) { | ||
| console.warn("[pong/viewed] Invalid code value"); |
Member
There was a problem hiding this comment.
nit: is it really a warning? Perhaps it's more info/debug level?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
/pong/viewedto return 400 for missing codes and 404 for invalid codes. Add tests covering rejected codes and successful view requests.Motivation
Prevent requests with missing or invalid codes from being acknowledged as recorded views.
Additional details
Invalid codes return 404, matching
/pong/click, without contacting upstream. Valid requests continue to return 201.Related issues and pull requests
Depends on: #513