Issue-28341 webextension.api documentId and parentDocumentId updates#28790
Conversation
rebloor
added
the
data:webext
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
…parentDocumentId-updates
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
Bot
added
the
merge conflicts 🚧
…parentDocumentId-updates
github-actions
Bot
removed
the
merge conflicts 🚧
Co-authored-by: Rob Wu <rob@robwu.nl>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "safari_ios": { | ||
| "version_added": "15", | ||
| "partial_implementation": true, | ||
| "notes": "`name` is supported, but `frameId` is not." | ||
| "version_added": "14" | ||
| }, |
There was a problem hiding this comment.
[bcd-linter] reported by reviewdog 🐶
| "safari_ios": { | |
| "version_added": "15", | |
| "partial_implementation": true, | |
| "notes": "`name` is supported, but `frameId` is not." | |
| "version_added": "14" | |
| }, |
|
The lint check found auto-fixable issues. Apply suggested changes (attributed to |
Removed partial implementation notes for Safari and Safari iOS.
Rob--W
left a comment
Rob--W
left a comment
There was a problem hiding this comment.
I didn't check whether the frameType/documentLifecycle properties are present in all listed APIs, and assume that you checked Chrome's documentation for these.
| } | ||
| } | ||
| }, | ||
| "name": { |
There was a problem hiding this comment.
name is a core part of the API and does not strictly need to be mentioned. But given that some properties are mentioned I'm fine with including it.
|
Thanks @Rob--W as for your query, yes, they would check against the Chrome documentation. |
rebloor
deleted the
Issue-28341-webextension.api-documentId-and-parentDocumentId-updates
branch
2 participants
Summary
There is updates to add details to cover Safari support for documentId and parentDocumentId. More information on changes see the related content PR. (mdn/content#42786)
Related issues
Fixes #28341
Related content changes in (mdn/content#42786)