fix(lib): derive GT phase from allele strings vs ref column#115
Merged
Conversation
The GT parser previously only recognized VCF-standard "0|1" and "1|0" formats. Input data with allele-string GT values (e.g., "A|C", "G|T") was silently treated as unphased, causing per_donor phased analysis to produce identical results to unphased. Now supports two GT formats: 1. Numeric: "0|1" or "1|0" (VCF standard) 2. Allele: "X|Y" where X,Y are allele strings - derives phase by comparing to the ref column Fix verified: - OLD: per_donor phased == unphased (λ_GC diff = 0.000) - FIXED: per_donor phased ≠ unphased (λ_GC diff = 0.395) - Phased λ_GC (1.106) closer to 1.0 than unphased (1.501) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GT parser previously only recognized VCF-standard
"0|1"and"1|0"formats. Input data with allele-string GT values (e.g.,"A|C","G|T") was silently treated as unphased, causingper_donorphased analysis to produce identical results to unphased.Changes
Modified
rust/src/lib.rsto support two GT formats:"0|1"or"1|0""X|Y"- derives phase by comparing to the ref columngt = 0(ref on hap1)gt = 1(ref on hap2)Verification
Test plan
cargo test)🤖 Generated with Claude Code