fix(macos): seal stdin on POSIX toolchain install (first-run Enter-press hang)#163
Merged
Merged
Conversation
…ess hang) First-run toolchain install (e.g. llvm@20.1.7) paused waiting for the user to press Enter on macOS — the '需要回车才能继续' report. The direct `xlings install -y` path sealed stdin only on Windows; POSIX 'kept stdin open to stay conservative', so xlings or a grandchild (curl/git/xcode-select/brew prompt) could block on a terminal read. `-y` already makes it non-interactive, so the seal only removes spurious blocking. Seal stdin on POSIX too (</dev/null; Windows keeps <NUL) on both the direct path and the NDJSON interface fallback. Build: clean self-host.
Sunrisepeak
added a commit
that referenced
this pull request
Jun 24, 2026
Maps each symptom reported in #43 to its root cause, fix/status and the PR/doc that handles it: - headline -lSystem link failure -> #162 (-isysroot + sdk_path hardening) - first-run stdin hang -> #163 - ninja 145s / sub-index 404 -> tracked in #164 todo (non-blocking) - VS Code xattr / config-hook fail -> xlings recipe side (non-mcpp) The cross-platform CDB e2e in this PR (76) doubles as the macOS link regression guard: mcpp build links, so a -lSystem regression turns it red. CI-verified that 76 actually runs+passes on linux/macos/windows. Closes #43
Sunrisepeak
added a commit
that referenced
this pull request
Jun 24, 2026
…#165) * test(e2e): assert compile_commands.json is generated on all platforms Add a dedicated e2e (no requires → runs Linux/macOS/Windows) that builds a minimal `mcpp new` project and verifies the Clang compilation database is emitted at the project root: file exists + non-empty, top-level JSON array, required keys (directory/file + command|arguments), an entry for src/main.cpp, and a deeper python json parse where available. CDB generation is unconditional in the ninja backend (write_compile_commands), so this guards the IDE/clangd contract directly. Existing CDB tests cover specifics (47 prebuilt-module-path abs, 59 std flag, gcc-only); this is the plain cross-platform existence+validity guarantee. Verified: 47 already passes on Windows/macOS CI, confirming the build path works there. * docs(issue43): consolidated macOS first-run triage + close-out record Maps each symptom reported in #43 to its root cause, fix/status and the PR/doc that handles it: - headline -lSystem link failure -> #162 (-isysroot + sdk_path hardening) - first-run stdin hang -> #163 - ninja 145s / sub-index 404 -> tracked in #164 todo (non-blocking) - VS Code xattr / config-hook fail -> xlings recipe side (non-mcpp) The cross-platform CDB e2e in this PR (76) doubles as the macOS link regression guard: mcpp build links, so a -lSystem regression turns it red. CI-verified that 76 actually runs+passes on linux/macos/windows. Closes #43
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-run toolchain install (llvm@20.1.7) pauses waiting for Enter on macOS — the "需要回车才能继续" report.
The direct
xlings install -ypath sealed stdin only on Windows; POSIX "kept stdin open to stay conservative", so xlings or a grandchild (curl/git/xcode-select/brew prompt) can block on a terminal read. The earlier comment even noted Windows had the same Enter-spam before its seal — macOS now reproduces it.-yalready makes the install non-interactive, so the seal only removes spurious blocking.Seal stdin on POSIX too (
</dev/null; Windows keeps<NUL) on both the direct path and the NDJSON interface fallback (NDJSON-over-stdout +yes:true, never needs the terminal).Build: clean self-host.