ci: parallelize e2e suite + per-test timing#157
Merged
Conversation
The linux job ran build → unit → e2e (~18m) → toolchain matrix → integration all in series (~34m wall-clock). Move the e2e suite to its own workflow (ci-linux-e2e.yml) that runs in PARALLEL on the same warm cache lineage, so the per-PR critical path becomes max(build+matrix, build+e2e) instead of their sum. ci-linux.yml keeps build + unit/integration + toolchain matrix + the xlings integration build; its toolchain steps no longer depend on e2e's warm-ups (GCC uses the mcpp.toml-pinned default already in the sandbox; the musl --target build auto-installs on demand). Also instrument tests/e2e/run_all.sh: each test now prints its elapsed time (portable ms timer — bash 5 EPOCHREALTIME, falling back to whole-second date), and the summary prints a slowest-first table + executed-total, so the long-pole tests surface for future sharding/optimization instead of hiding behind 'OK'. NOTE: the new check 'e2e suite (linux x86_64, self-host)' must be added to main's required-status-checks ruleset to gate merges (admin action).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
build + test (linux x86_64, self-host)job ran everything in series — build → unit tests → e2e (~18m) → toolchain matrix (3 clean rebuilds) → xlings integration — for a ~34m critical path per PR.What
1. Split the e2e suite into its own parallel workflow (
ci-linux-e2e.yml).target/), so it restores a warm build; the only added cost vs. inline is one warmmcpp build.ci-linux.ymldrops the e2e step and keeps build + unit/integration + toolchain matrix + the xlings integration build. Its toolchain steps no longer rely on e2e's warm-ups: GCC uses themcpp.toml-pinnedgcc@16.1.0(already in the sandbox), and the musl--targetbuild auto-installsgcc@15.1.0-muslon demand.max(build+matrix, build+e2e)instead of their sum.2. Per-test timing in
tests/e2e/run_all.sh.PASS: 12_foo.sh (3.40s)), via a portable ms timer (bash 5EPOCHREALTIME, falling back to whole-seconddateon old bash like macOS/bin/bash3.2).OK.The new check
e2e suite (linux x86_64, self-host)must be added tomain's required-status-checks ruleset, otherwise PRs could merge without e2e passing. The existingbuild + test (linux x86_64, self-host)check name is unchanged.