Implement undo functionality enhancements for SAM2 points tool#1356
Open
GlenCarpenter wants to merge 1 commit intomcmonkeyprojects:masterfrom
Open
Implement undo functionality enhancements for SAM2 points tool#1356GlenCarpenter wants to merge 1 commit intomcmonkeyprojects:masterfrom
GlenCarpenter wants to merge 1 commit intomcmonkeyprojects:masterfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SAM2 point/undo alignment
Keeps SAM2 point state in sync with the canvas undo stack.
Each time a SAM2 mask result is applied, a snapshot of the current points is attached to the latest history entry. When that entry is undone, the snapshot is restored so the visible points always match the canvas state.
A new
onBeforeHistoryUndo()hook cancels any in-flight SAM2 request before the undo is applied, preventing a late response from overwriting the freshly-restored canvas.Point state is also fully reset on tool deactivation, mask clear, layer change, and new image load to prevent stale snapshots from carrying over between sessions.