Conversation
`quarto-lua-modules` moves to 2.5.0, which adds `Checker:option` for reading what the schema resolves an option to. `quarto-wizard` moves to 3.6.3, whose `schema.lua` is unchanged from the vendored 3.6.0.
mcanouil
added
the
Type: Dependencies ⬆️
No schema in the fleet declared `additionalProperties: false`, so a key nested inside an option was never checked and a typo did nothing in silence. The nested object blocks now declare it. A union such as `type: [string, object]` is unaffected in its string form, and the extension's own documented configuration still passes.
mcanouil
added
Type: Enhancement 💡
mcanouil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No schema in the fleet declared
additionalProperties: false, so a key nested inside an option was never checked. A typo in a nested setting did nothing, in silence. The nested object blocks in this schema now declare it.Verified by rendering this extension's own documented configuration, which passes with nothing reported, and then by introducing one typo:
A union such as
type: [string, object]keeps its string form untouched; only the object form is checked. That was measured before the change was made.One asymmetry worth knowing, and it is the validator's rather than this schema's. An unknown key at the top level of an extension's options is reported as a warning, being advice rather than a failure, while an unknown nested key is reported as an error. Neither stops a render.
The first commit updates the vendored modules to
quarto-lua-modules2.5.0 andquarto-wizard3.6.3.