fix: resolve outstanding code review findings on main - #67
Merged
Merged
Conversation
Ports the still-relevant review comments from supra-merged seed-packet, database, and media work onto main's current implementation: - ops/database: deleteField inverse now captures and restores the removed cell values, so undo restores data instead of an empty column. - ops/media: deleteGroup inverse remembers former asset memberships and restores them on undo. - panels/media: render stored blobs on the media board instead of showing only the filename. - surfaces/database: always show an Unassigned kanban column; group multi_select cells by array membership; give multi_select cells a real array editor instead of corrupting them via the scalar input. - store/bundle: remap RelationField.targetDocId and GardenRef.documentId after an import ID collision so imported topology stays intact. - store/workspace: serialize concurrent packet planting; add a store-driven packet preview overlay reachable from the sidebar (complex packets are previewed/confirmed before planting). - packets: pre-allocate base ids before sprouting so a relation may target any base regardless of declaration order. Adds regression tests for deleteField/deleteGroup undo, forward-referencing relations, plus typecheck/lint/build clean (tests 216 passed).
This was referenced Sep 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ports the still-relevant review comments from PRs #62/#63/#64 (seed-packet/database/media work) onto
main's current implementation, fixing real bugs that are live inmaintoday. PRs #62/#63/#64 themselves are stale duplicates whose content main already merged in newer form (see closure comments there); this PR lands the fixes those reviews called for.Fixes
deleteFieldinverse now captures & restores removed cell values, so Undo brings data back instead of an empty column (P1).deleteGroupinverse restores former asset memberships on Undo (P2).multi_selectcells by array membership;multi_selectcells get a real array editor (2x P2).RelationField.targetDocId/GardenRef.documentIdafter an import ID collision so imported topology stays intact (P1).Verification
npm run typecheck✅npm run lint(no new errors) ✅npm run test— 216 passed ✅npm run build✅Test plan