msgconv: preserve Slack user group mentions - #91
Open
0x-chad wants to merge 1 commit into
Open
Conversation
0x-chad
force-pushed
the
fix/user-group-mentions
branch
from
August 2, 2026 19:00
b0e56c1 to
a26a9aa
Compare
0x-chad
changed the title
0x-chad
force-pushed
the
fix/user-group-mentions
branch
from
August 6, 2026 20:08
a26a9aa to
1e0384d
Compare
0x-chad
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<!subteam^ID|@handle>mentions as@handle<!subteam^ID>fallbacks instead of dropping themSlack commonly provides only the user-group ID, including in rich-text
usergroupelements. Resolving those IDs to handles can be handled separately if desired; this PR is intentionally limited to lossless conversion.Testing
go test -count=1 ./pkg/connector ./pkg/msgconv/...go test -race -count=1 ./pkg/connector ./pkg/msgconv/...Fixes #90