Skip to content

Fix parsing of array types #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthijscox merged 3 commits into from
Sep 10, 2025
Merged

Fix parsing of array types #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2933ebc
Fix parsing of array types
JulianvDoorn Sep 9, 2025
79c2eae
Bump package version
JulianvDoorn Sep 9, 2025
733954d
Added test for array types
JulianvDoorn Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "JSONSchemaGenerator"
uuid = "b10a6b5e-eaef-4b72-b159-8e5005e98e8e"
authors = ["matthijscox <matthijs.cox@gmail.com> and contributors"]
version = "0.3.0"
version = "0.3.1"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Expand Down
2 changes: 1 addition & 1 deletion src/JSONSchemaGenerator.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ function schema(
reference_types = reference_types,
dict_type = dict_type,
)
d = _generate_json_object(schema_type, settings)
d = _generate_json_type_def(schema_type, settings)
return d
end

Expand Down
15 changes: 15 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,3 +332,18 @@ end
@test_throws Exception bad_combo_schema2 = JSONSchemaGenerator.schema(TestTypes.BadBooleanCombinationSchema2)
end
end

@testset "Vector{T} Regression Test" begin
@testset "Int" begin
int_array_schema = JSONSchemaGenerator.schema(Vector{Int})
@test int_array_schema["type"] == "array"
@test int_array_schema["items"]["type"] == "integer"
end

@testset "Nested" begin
nested_array_schema = JSONSchemaGenerator.schema(Vector{Vector{Int}})
@test nested_array_schema["type"] == "array"
@test nested_array_schema["items"]["type"] == "array"
@test nested_array_schema["items"]["items"]["type"] == "integer"
end
end
Loading