Fix OutgoingIntegrationRequestsTimeout config key name and default value#8943
Open
mgdelacroix wants to merge 2 commits intomasterfrom
Open
Fix OutgoingIntegrationRequestsTimeout config key name and default value#8943mgdelacroix wants to merge 2 commits intomasterfrom
mgdelacroix wants to merge 2 commits intomasterfrom
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the Mattermost documentation for the “Integration request timeout” setting by aligning the documented config.json key name, environment variable name, and default value with the actual server configuration behavior.
Changes:
- Fixes the documented
config.jsonkey fromOutgoingIntegrationRequestsDefaultTimeouttoOutgoingIntegrationRequestsTimeout. - Fixes the documented environment variable to
MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT. - Updates the documented default timeout from 3 seconds to 30 seconds, including the inline
config.jsonexample.
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA a80a826 |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA fe96543 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three errors in the Integration request timeout config setting documentation:
:configjson:wasOutgoingIntegrationRequestsDefaultTimeout— this is the name of an internal Go constant, not theconfig.jsonkey. The correct key isOutgoingIntegrationRequestsTimeout.:environment:wasMM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTDEFAULTTIMEOUT(derived from the wrong key). Corrected toMM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT.3seconds. The actual default is30seconds (set inconfig.SetDefaults, enforced byIsValidwhich rejects<= 0).Ticket Link
https://mattermost.atlassian.net/browse/MM-68319