Skip to content

Fix OutgoingIntegrationRequestsTimeout config key name and default value#8943

Open
mgdelacroix wants to merge 2 commits intomasterfrom
fix/outgoing-integration-timeout-docs
Open

Fix OutgoingIntegrationRequestsTimeout config key name and default value#8943
mgdelacroix wants to merge 2 commits intomasterfrom
fix/outgoing-integration-timeout-docs

Conversation

@mgdelacroix
Copy link
Copy Markdown
Member

Summary

Fixes three errors in the Integration request timeout config setting documentation:

  • :configjson: was OutgoingIntegrationRequestsDefaultTimeout — this is the name of an internal Go constant, not the config.json key. The correct key is OutgoingIntegrationRequestsTimeout.
  • :environment: was MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTDEFAULTTIMEOUT (derived from the wrong key). Corrected to MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT.
  • Default value was documented as 3 seconds. The actual default is 30 seconds (set in config.SetDefaults, enforced by IsValid which rejects <= 0).

Ticket Link

https://mattermost.atlassian.net/browse/MM-68319

@mgdelacroix mgdelacroix added the 1: Dev Review Requires review by a core commiter label May 7, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dd05cfd4-b1d2-49ab-99e8-f08e7aed0430

📥 Commits

Reviewing files that changed from the base of the PR and between a80a826 and fe96543.

📒 Files selected for processing (1)
  • source/administration-guide/configure/integrations-configuration-settings.rst
🚧 Files skipped from review as they are similar to previous changes (1)
  • source/administration-guide/configure/integrations-configuration-settings.rst

📝 Walkthrough

Walkthrough

The documentation updates the integration request timeout setting to use .ServiceSettings.OutgoingIntegrationRequestsTimeout / MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT and changes the documented default from 3 seconds to 30 seconds.

Changes

Integration Request Timeout Configuration

Layer / File(s) Summary
Configuration Setting Documentation
source/administration-guide/configure/integrations-configuration-settings.rst
Config directive updated from .ServiceSettings.OutgoingIntegrationRequestsDefaultTimeout / MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTDEFAULTTIMEOUT to .ServiceSettings.OutgoingIntegrationRequestsTimeout / MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT; feature summary and inline default changed from 3 to 30 seconds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: fixing the config key name and updating the default value for the OutgoingIntegrationRequestsTimeout setting.
Description check ✅ Passed The description is directly related to the changeset, providing clear context about the three documentation errors being fixed and referencing the relevant ticket.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/outgoing-integration-timeout-docs

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the Mattermost documentation for the “Integration request timeout” setting by aligning the documented config.json key name, environment variable name, and default value with the actual server configuration behavior.

Changes:

  • Fixes the documented config.json key from OutgoingIntegrationRequestsDefaultTimeout to OutgoingIntegrationRequestsTimeout.
  • Fixes the documented environment variable to MM_SERVICESETTINGS_OUTGOINGINTEGRATIONREQUESTSTIMEOUT.
  • Updates the documented default timeout from 3 seconds to 30 seconds, including the inline config.json example.

Comment thread source/administration-guide/configure/integrations-configuration-settings.rst Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Newest code from mattermost has been published to preview environment for Git SHA a80a826

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Newest code from mattermost has been published to preview environment for Git SHA fe96543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1: Dev Review Requires review by a core commiter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants