Skip to content

Align HA sysctl values with load-test server config#8939

Merged
agarciamontoro merged 2 commits intomasterfrom
fix.sysctl.values
May 7, 2026
Merged

Align HA sysctl values with load-test server config#8939
agarciamontoro merged 2 commits intomasterfrom
fix.sysctl.values

Conversation

@agarciamontoro
Copy link
Copy Markdown
Member

@agarciamontoro agarciamontoro commented May 6, 2026

Summary

The sysctl block on the High Availability deployment page targets Mattermost server hosts but mirrored the load-test agent (client) values, which are tuned for a different role. Align it with the serverSysctlConfig used by mattermost-load-test-ng to validate large concurrent-user deployments:

  • Raise tcp_rmem/tcp_wmem max from 625000 to 2500000 (4x BDP) and expand the comment to describe the autotuning ceiling.
  • Raise net.core.{r,w}mem_max from 312500 to 16777216 and dedupe the surrounding comments (mirrors Fix overridden net.core.{r,w}mem_max values mattermost-load-test-ng#987, which removed the redundant double-assignment that set the same keys twice for UDP and TCP).
  • Drop rmem_default/wmem_default/tcp_mem, which only belong in the client/agent block and were copied here in error.

Ticket Link

--

The sysctl block on the High Availability deployment page targets
Mattermost server hosts but mirrored the load-test agent (client)
values, which are tuned for a different role. Align it with the
serverSysctlConfig used by mattermost-load-test-ng to validate large
concurrent-user deployments:

- Raise tcp_rmem/tcp_wmem max from 625000 to 2500000 (4x BDP) and
  expand the comment to describe the autotuning ceiling.
- Raise net.core.{r,w}mem_max from 312500 to 16777216 and dedupe the
  surrounding comments (mirrors mattermost-load-test-ng#987, which
  removed the redundant double-assignment that set the same keys
  twice for UDP and TCP).
- Drop rmem_default/wmem_default/tcp_mem, which only belong in the
  client/agent block and were copied here in error.
@agarciamontoro agarciamontoro requested a review from cpoile May 6, 2026 13:36
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

📝 Walkthrough

Walkthrough

Documentation update to the high-availability cluster deployment guide. Kernel networking memory parameters for WebSocket connections are increased: tcp_rmem and tcp_wmem to 2500000, net.core.rmem_max and net.core.wmem_max to 16777216, with explanatory comments added.

Changes

Kernel Tuning Documentation

Layer / File(s) Summary
Tuning Parameters
source/administration-guide/scale/high-availability-cluster-based-deployment.rst
Kernel networking memory parameters increased in the "Increase the number of WebSocket connections" section: tcp_rmem and tcp_wmem set to 2500000; net.core.rmem_max and net.core.wmem_max set to 16777216. Clarifying comments added.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: aligning High Availability sysctl configuration values with the load-test server configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly relates to the changeset, detailing specific sysctl parameter updates and their alignment with load-test server configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix.sysctl.values

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{}

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Newest code from mattermost has been published to preview environment for Git SHA d05121f

@agarciamontoro agarciamontoro merged commit 1378a37 into master May 7, 2026
4 of 5 checks passed
@agarciamontoro agarciamontoro deleted the fix.sysctl.values branch May 7, 2026 12:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Newest code from mattermost has been published to preview environment for Git SHA 71f3004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants