fix(ci): make sdk check name mergify-safe - #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mergify could not queue approved PR #725 even though its GitHub Actions SDK check was green. The required check was named
@astra/sdk (typecheck, test+coverage, build). Mergify reserves a leading@for GitHub-App-qualified checks, so its injected branch-protection condition treated that check as an invalid/unmatched qualifier and left the PR waiting indefinitely.Rename the workflow job to
Astra SDK (typecheck, test+coverage, build), which remains a stable required check while avoiding the reserved syntax. Add a repository validator guard so the old name cannot return silently, and document the one-time branch-protection migration.After this PR is merged and the new check has appeared once, update
mainbranch protection: remove@astra/sdk (typecheck, test+coverage, build)and addAstra SDK (typecheck, test+coverage, build). Keep the old entry until the new check has completed once; removing it first would weaken the protection gate, while retaining it permanently would block every PR after the rename.User impact
Approved PRs can enter the existing serial Mergify queue and be merged after the required checks pass. Queue policy, approval requirements, branch protection, and CI coverage remain unchanged. No runtime, API, storage, release, or credential changes are included.
Verification
python3 -m unittest discover -s scripts/ci -p 'test_*.py'— 57 tests passgo run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 .github/workflows/static-checks.yml— passgit diff --check— passRelated observation
The failure was reproduced on PR #725: Mergify's queue status showed only the SDK check condition unsatisfied, while the GitHub check and all other queue conditions were successful. This PR does not auto-close or modify #725.