Skip to content

Allow manually dispatching the PHPCS workflow [ignore_release] - #197

Merged
AltamashShaikh merged 2 commits into
5.x-devfrom
phpcs-run-on-dev-branch-push
Aug 14, 2026
Merged

Allow manually dispatching the PHPCS workflow [ignore_release]#197
AltamashShaikh merged 2 commits into
5.x-devfrom
phpcs-run-on-dev-branch-push

Conversation

@snake14

@snake14 snake14 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Description

The PHPCS badge for this plugin (shown on the plugins build dashboard) has displayed "failing" since December 2025 even though PHPCS passes on all recent pull requests. The badge shows the latest workflow run whose head branch matches the default branch, and that run is a failed December 2025 run from a fork PR whose branch was named 5.x-dev. Because the workflow only triggers on pull_request, no future run can replace that badge state on its own.

This adds a workflow_dispatch trigger so the workflow can be run manually; a single dispatch on 5.x-dev after merging refreshes the badge. PHPCS otherwise stays PR-only, since it is already enforced on every PR before merge. CI-only change with no runtime effect.

Issue No

NA

Steps to Replicate the Issue

  1. Open the plugins build dashboard and look at the VisitorGenerator PHPCS badge.
  2. Expected: the badge reflects the current state of the code on 5.x-dev.
  3. Actual: the badge shows a failing December 2025 run and can never update, as the workflow only runs on pull requests.

Checklist

  • [NA] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✖] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

The README/dashboard badge reads the latest default-branch run, which has
been a failed Dec 2025 run from a fork PR branch named 5.x-dev. Push runs
keep the badge reflecting the actual state of the dev branches.
@snake14 snake14 changed the title Run PHPCS on pushes to dev branches Run PHPCS on pushes to dev branches [ignore_release] Aug 14, 2026
@snake14
snake14 force-pushed the phpcs-run-on-dev-branch-push branch from d66025a to 24d2879 Compare August 14, 2026 02:49
PHPCS is already enforced on every PR before merge, so per-push runs add
nothing. A single manual dispatch on 5.x-dev is enough to refresh the
stale badge.
@snake14 snake14 changed the title Run PHPCS on pushes to dev branches [ignore_release] Allow manually dispatching the PHPCS workflow [ignore_release] Aug 14, 2026
@snake14
snake14 requested a review from AltamashShaikh August 14, 2026 03:54
@AltamashShaikh
AltamashShaikh merged commit 25b8acf into 5.x-dev Aug 14, 2026
8 of 9 checks passed
@AltamashShaikh
AltamashShaikh deleted the phpcs-run-on-dev-branch-push branch August 14, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants