Add optional word prefix to order ID since they don't have to be just numeric - #184
Merged
Conversation
michalkleiner
force-pushed
the
string-order-id
branch
from
November 12, 2025 00:59
d6e9dba to
7c30ff3
Compare
AltamashShaikh
approved these changes
Nov 12, 2025
AltamashShaikh
left a comment
AltamashShaikh
left a comment
Contributor
There was a problem hiding this comment.
LGTM, doTrackEcommerceOrder expects the orderID to be string|int, so should be okay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Better reflecting real-word order IDs that don't have to be just numeric.
Note: not sure when the next release date is planned for, anyone can change it whatever it needs to be. Thanks!
Issue No
Related to testing for DEV-19682.
Checklist