Skip to content

Fix interactive session check only to restrict TTY #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matiboux merged 1 commit into from
Aug 29, 2026
Merged

Fix interactive session check only to restrict TTY #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions dockerc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,19 +1075,10 @@ if [ "$CONTEXT" != '--' ]; then

fi

is_interactive_session()
is_tty_session()
{
# Non-interactive if explicitly requested via environment variable
if [ "$DEBIAN_FRONTEND" = 'noninteractive' ]; then
return 1
fi

# Non-interactive if stdin and/or stdout is not a tty (e.g. piped, redirected, or no tty allocated)
if ! [ -t 0 ] || ! [ -t 1 ]; then
return 1
fi

return 0
# TTY session unless requested otherwise or stdin/stdout are not TTYs
[ "${DEBIAN_FRONTEND}" != 'noninteractive' ] && [ -t 0 ] && [ -t 1 ]
}

handle_compose_presets_up()
Expand Down Expand Up @@ -1340,11 +1331,15 @@ handle_compose_presets_run()
if [ -n "$COMPOSE_RUN_ENTRYPOINT" ]; then
COMPOSE_ARGS="$COMPOSE_ARGS --entrypoint $COMPOSE_RUN_ENTRYPOINT"
fi
if [ "$COMPOSE_RUN_INTERACTIVE" = 'true' ] && is_interactive_session; then
if [ "$COMPOSE_RUN_INTERACTIVE" = 'true' ]; then
COMPOSE_ARGS="$COMPOSE_ARGS -i"
fi
if [ "$COMPOSE_RUN_TTY" = 'true' ] && is_interactive_session; then
COMPOSE_ARGS="$COMPOSE_ARGS -t"
if [ "$COMPOSE_RUN_TTY" = 'true' ]; then
if ! is_tty_session; then
COMPOSE_RUN_TTY='false'
else
COMPOSE_ARGS="$COMPOSE_ARGS -t"
fi
fi
if [ "$COMPOSE_RUN_SERVICE_PORTS" = 'true' ]; then
COMPOSE_ARGS="$COMPOSE_ARGS --service-ports"
Expand Down
Loading