Repository navigation
Respect non interactive sessions - #114
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how the
dockercscript determines whether to allocate interactive and TTY flags when running Docker Compose commands. The main change is the introduction of a new function to more robustly detect interactive sessions, ensuring that flags like-iand-tare only used when appropriate.Session detection improvements:
is_interactive_sessionfunction to check if the session is interactive by verifying both theDEBIAN_FRONTENDenvironment variable and whether stdin/stdout are TTYs.Compose run argument handling:
handle_compose_presets_run()to only add the-i(interactive) and-t(TTY) flags if the session is interactive, preventing errors when running in non-interactive environments.Fixes #113