Fix for #30. - #31
Open
tonyastolfi wants to merge 2 commits into
Open
Conversation
vidyasilai
reviewed
Aug 13, 2026
vidyasilai
left a comment
vidyasilai
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just one small question about the libbacktrace dependency.
| self.requires("yaml-cpp/[>=0.9.0 <1]") | ||
| self.requires("zlib/1.3.1", **OVERRIDE) | ||
|
|
||
| # boost/1.88.0 and ninja/1.13.2 depend (exactly) on libbacktrace/cci.20210118 |
Collaborator
There was a problem hiding this comment.
Is removing the dependency on libbacktrace just to get rid of the direct dependency turtle_kv has on the library? Or is it meant to also disable the boost dependency as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30
Fixed the
ChangeLog::synchang by moving the code that adds blocks to the output vector inactivate_blocks(change_log_writer.cpp) to before the conditional that skips the rest of the loop body if the current block is already trimmed.Added regression test
ChangeLogTest.SyncAggressiveTrimto verify the bug and the fix.Update: Also removed
libbacktracerequirement.