Delete dead code - #210
Open
gabrielbornstein wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR deletes dead code.
The total code audited includes:
- stable_string_store
- lru_clock
- sha256
- crc
- fuse stuff
- llfs_fuse/
- worker_task
- inode
- file_log_driver.*
- file_segment_ref.*
- filesystem_page_device.*
- old TurtleDB snapshot stuff
- packed_log_page_header.* ?
- raw_volume_log_data_parser
- trie (once packed art / blocked leaf pages are merged)
- old LogDevice (pre ioring_logdevice2)
- llfs_cli/*
The code that was NOT deleted includes:
- trie (dependent code not merged yet)
- packed_log_page_header.* ? (still seems to be in use)
- raw_volume_log_data_parser (still seems to be in use)
- old LogDevice (appeared to already have been deleted)
- file_segment_ref (still seems to be in use)
These deletions improve line code coverage from 67% to 74%.
NOTE: When testing locally, the following test failed when building with coverage flags, but passed without them: