Bump strnum to 2.4.2 - #41
Merged
Merged
Conversation
The copy esbuild inlines into dist/extension.js: core's dist imports strnum rather than bundling it (`import toNumber from 'strnum'` in DictionaryXmlFast.js), so it is THIS lockfile that decides which version ships, not core's — the two repos' bumps are independent, and core's own is PR mathworks/data-explorer-core#64. 2.4.2 is in range of every "^2.4.1" asking for it, so the lockfile alone moves. The resolved URL was rewritten back to registry.npmjs.org after the install; integrity is content-based and unaffected, and check:leak confirms all 646 resolutions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lockfile-only patch bump. 2.4.2 is in range of every
"^2.4.1"asking for it, so there is nopackage.jsonedit and nooverridesentry.This is the copy that ships: core's prebuilt
dist/imports strnum rather than bundling it (import toNumber from 'strnum'indist/datamodel/parser/DictionaryXmlFast.js), so esbuild resolves it out of this repo'snode_moduleswhen it inlines core intodist/extension.js. The two repos' bumps are therefore independent — core's is mathworks/data-explorer-core#64 — and neither needs a core release or a pin bump to take effect.resolvedrewritten back toregistry.npmjs.orgafter the install;integrityis content-based and unaffected.npm run check:leakconfirms all 646 resolutions.Local run note, for the record:
npm teston this Mac flakesrowBuilder.test.ts > builds every row instead of overflowing the argument limit—Test timed out in 5000msat 5683ms for a 200,000-row build. It passes in isolation in 1.4s, and passed in the full suite an hour ago on #39; it is machine load, not this bump. CI is the gate.