Bump to 1.34.0: a project's labels and run order read as MATLAB writes them - #60
Merged
Merged
Conversation
Two facts that are in the fixtures rather than in project_truth.json: FixedPathMultiFile is the layout a NEW project gets — parityLib is never converted and is in it — so convertDefinitionFiles is the opt-out rather than the opt-in, and that layout is the shape most .prj files in the wild are in. And the conversion does not recurse into referenced projects: each format's parityLib keeps its own .prj and its own fixedPathV2 store, which is why a Toml project can hold a reference to an XML one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases the three project-parser fixes from #59:
ReadOnlyis read by its per-element vocabulary, so a label the user added is no longer drawn as one of MATLAB's built-ins.Extension(what a freshly built project writes) is no longer listed in reverse run order.Carries one extra commit: two facts about the corpus trees that
project_truth.jsondoes not record —FixedPathMultiFileis the layout a new project gets, and the conversion does not recurse into referenced projects.