fix(crystal-toolkit): stabilize legacy Storybook scenes and hover cleanup - #765
Open
HyaCiovo wants to merge 1 commit into
Open
fix(crystal-toolkit): stabilize legacy Storybook scenes and hover cleanup#765HyaCiovo wants to merge 1 commit into
HyaCiovo wants to merge 1 commit into
Conversation
Author
Atom hover state restorationFixed an existing hover-state restoration bug in the Crystal Toolkit scene. Previously, atom highlighting behaved differently depending on where the pointer
The root cause was that The updated implementation now:
This ensures that at most one atom is highlighted at any time and that every |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #697
Major changes:
atom to another could leave the previous atom highlighted instead of restoring
its original element color.
TypeScript constructor parameter properties being emitted as JavaScript
privatesyntax by the current Storybook/Babel pipeline.src/assets/fonts.css, whichno longer exists in the repository.
@babel/preset-reactas an explicit development dependency because itis referenced directly by the existing Babel configuration.
initialization without later calling
dispose()on an undefined controlsinstance.
inset, and debug helper resources during cleanup.
RadiusTubeBufferGeometryconstruction from legacyfunction/prototype inheritance to a proper
BufferGeometrysubclass.attributes, and JSON serialization while resolving the runtime error:
Class constructor BufferGeometry cannot be invoked without 'new'.and legacy BufferGeometry methods used by this module, without introducing a
project-wide Three.js type migration.
Todos
No functional work remains for this PR.
Follow-up work that is intentionally out of scope:
React type declarations in the legacy Enzyme dependency tree.
Storybook, Babel, React, and Three.js stack.
geometry construction, and atom-to-atom hover transitions when the project
test environment is modernized.
Checklist
Storybook error display.
Cannot read properties of undefined (reading 'dispose')error.RadiusTubeBufferGeometry.tsno longer produces diagnosticsrelated to its custom fields or inherited geometry methods.
git diff --check.duplicate React declarations from the legacy Enzyme dependency tree.