Repository navigation
make solution - #1922
make solution#1922insomniaorno wants to merge 3 commits into
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The row-generation logic correctly creates the six required cells and calculates age and century as specified, but the implementation does not meet the requirement to use the provided people.json data. In src/scripts/main.js, replace the hardcoded people array with the required import and generate the rows from that imported data; otherwise, the table may not reflect the provided source. The relevant code location is the hardcoded data declaration, though no line numbers were available in the review materials. The core table logic is a good start, and using the required data source will complete this requirement.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The data processing in main.js meets the stated requirements, but the build is blocked: src/scripts/main.js:3 imports people.json while src/index.html:26 loads the script as a classic browser script. Parcel rejects this combination, so the test run stops before tests can complete. Mark the script as a module in the HTML (for example, with type="module") or configure the bundler to support the import another way. Once this is corrected, rerun the tests; the implementation itself otherwise looks good.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am approving this as an educational override to help you progress while learning. The row-generation logic correctly creates the six required cells and calculates age and century as specified. One important improvement is to replace the locally hardcoded people array in src/scripts/main.js with the imported people.json data, so the dashboard reflects the required source data. The available review does not provide line numbers, so I’ve identified the relevant file instead. You have a solid foundation here, and using the required data source will bring the implementation in line with the task.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| // write your code here | ||
| const dashboard = document.querySelector('.dashboard'); | ||
|
|
||
| people.forEach((person) => { |
There was a problem hiding this comment.
This iterates over the locally hardcoded people array, but the task requires generating rows from the imported people.json data. Use the imported array so the dashboard reflects the provided source data.
DEMO LINK